Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-8367

manual-approval-gate requires group precedence support

XMLWordPrintable

    • Pipelines Sprint Pioneers 37

      Description of problem:

      If the same user is part of multiple groups, for example, user2 is a member of both group1 and group2. Both groups appear in the approver list. 

      Prerequisites (if any, like setup, operators/versions):

      1.20.0

      Steps to Reproduce

      OSP 1.20.0

      MAG 0.7.0
       

      Actual results:

      ./tkn-approvaltask describe deployment-pipeline-run-hn9wd-approval-gate -n test
      📦 Name:            deployment-pipeline-run-hn9wd-approval-gate
      🗂  Namespace:       test
      🏷️  PipelineRunRef:  deployment-pipeline-run-hn9wd👥 Approvers
         * user1
         * user5
         * approver-group (Group)
         * approver-group2 (Group)👨‍💻 ApproverResponseName                       ApproverResponse     Message
      approver-group: user2      ✅                    ---
      approver-group2: user2     ✅                    ---🌡️  StatusNumberOfApprovalsRequired     PendingApprovals     STATUS
      2                             1                    Pending
       

      Expected results:

      Group precedence should be present

      Reproducibility (Always/Intermittent/Only Once):

      Always

      Additional info (Such as Logs, Screenshots, etc):

      ➜ oc get groups
      NAME              USERS
      approver-group    user1, user2
      approver-group2   user3, user2, user4
      approver-group3   user6
       

      Approve the approval task as user2:

              rh-ee-pbheeman Pavan Mandayam Bheeman
              rhn-support-sselvan Sri Vignesh Selvan
              Sri Vignesh Selvan Sri Vignesh Selvan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: