Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-8259

manual-approval-gate error: non approver user missing while approving

XMLWordPrintable

      Description of problem:

      After approving from group1 as user, group2/user cannot approve because non approver user4 not found

      Prerequisites (if any, like setup, operators/versions):

      MAG 0.7.0

      Steps to Reproduce

      1. Create 4 users

      2. add user1 and user2 to group1

      3. add user3 to group2

      4. create approval task and approve as user2. (Should succeed)

      5. now login as user3 and try to approve (failing)

      Actual results:

      Error: failed to approve approvalTask from namespace test: Approver: user4, is not present in the approvers list

      Expected results:

      ApprovalTask deployment-pipeline-run-z4c9l-approval-gate is approved in test namespace

      Reproducibility (Always/Intermittent/Only Once):

      Always

      Additional info (Such as Logs, Screenshots, etc):

      Approvaltask approvers list:

          params:
          - name: approvers
            value:
            - user
            - user1
            - group:approver-group  #(user1, user2)
            - group:approver-group2 #(user3)
      📦 Name:            deployment-pipeline-run-cz9xh-approval-gate
      🗂  Namespace:       test
      🏷️  PipelineRunRef:  deployment-pipeline-run-cz9xh
      👥 Approvers
         * user
         * user1
         * approver-group (Group)
         * approver-group2 (Group)
      👨‍💻 ApproverResponseName  ApproverResponse     Message
      approver-group: user2     ✅                    ---🌡️  StatusNumberOfApprovalsRequired     PendingApprovals     STATUS
      2                                    1                    Pending
      
      - apiVersion: openshift-pipelines.org/v1alpha1
        kind: ApprovalTask
        metadata:
          annotations:
            tekton.dev/last-applied-hash: fae4396a4a28deaa21efdebd6b60ce5ef23795b8fd3e9bccfc56bd668c62da3c
          creationTimestamp: "2025-08-01T07:41:40Z"
          generation: 2
          labels:
            tekton.dev/customRun: deployment-pipeline-run-ps65x-approval-gate
            tekton.dev/memberOf: tasks
            tekton.dev/pipeline: deployment-pipeline
            tekton.dev/pipelineRun: deployment-pipeline-run-ps65x
            tekton.dev/pipelineRunUID: c72c9cd2-535e-4a3c-bea3-edb687db326f
            tekton.dev/pipelineTask: approval-gate
          name: deployment-pipeline-run-ps65x-approval-gate
          namespace: test
          ownerReferences:
          - apiVersion: tekton.dev/v1beta1
            blockOwnerDeletion: true
            controller: true
            kind: CustomRun
            name: deployment-pipeline-run-ps65x-approval-gate
            uid: bb82f1ad-a69e-467c-a905-719f77a0355f
          resourceVersion: "436694"
          uid: 1a44b262-c317-4287-8fb7-b008b53ae411
        spec:
          approvers:
          - input: pending
            name: user
            type: User
          - input: pending
            name: user1
            type: User
          - input: approve
            name: approver-group
            type: Group
            users:
            - input: approve
              name: user2
          - input: pending
            name: approver-group2
            type: Group
          description: Approve deployment to production
          numberOfApprovalsRequired: 2
        status:
          approvalsReceived: 1
          approvalsRequired: 2
          approvers:
          - user
          - user1
          - approver-group
          - approver-group2
          approversResponse:
          - groupMembers:
            - name: user2
              response: approved
            name: approver-group
            response: approved
            type: Group
          startTime: "2025-08-01T07:41:40Z"
          state: pending
      kind: List
      metadata:
        resourceVersion: ""
      

       *

      When retried again noticed only the approvergroup user2 only can approve all other users are getting this user4 not found in approver list error

              ppunamiy Puneet Punamiya
              rhn-support-sselvan Sri Vignesh Selvan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: