-
Bug
-
Resolution: Unresolved
-
Major
-
Pipelines 1.19.0
-
5
-
False
-
-
False
-
-
Enhancement
-
Proposed
-
-
Description of problem:
After applying config map with invalid values like(ttlSecondsAfterFinished: 60s) instead of
ttlSecondsAfterFinished: 60. there is currently no mechanism to validate the configmap applied is correct. unless the logs shows some error. But the previously applied correct configuration is applied to prune the pipelineruns.
Users might not be aware if the invalid configmap applied with 2m is valid or not.
Prerequisites (if any, like setup, operators/versions):
Pruner with 1.19.0
Steps to Reproduce
1. Apply below config in pruner configmap
global-config: |- enforcedConfigLevel: global ttlSecondsAfterFinished: 60
2. Now it prunes the pipelinerun after 60sec
3. Now apply a invalid configmap value
global-config: |- enforcedConfigLevel: global ttlSecondsAfterFinished: 2m
4. Now the configmap is applied without any error.
5. Now the pipelineruns are pruned after 60sec
6. Only the pruner logs shows the error.
Actual results:
Pipelinerun removed after 60sec
Expected results:
Some error mechanism to handle such issues
Reproducibility (Always/Intermittent/Only Once):
Always
Additional info (Such as Logs, Screenshots, etc):
Error from pruner logs:
Error loading pruner global config{error 26 0 error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go struct field PrunerConfig.SuccessfulHistoryLimit of type int32
- relates to
-
SRVKP-9253 Address Pruner comment to set limits to allowable pruner settings
-
- On QA
-
- links to