Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-7224 Pruner development tasks
  3. SRVKP-7687

Fix bug related to Namespace level config in pruner

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Done
    • Icon: Major Major
    • None
    • None
    • Pruner
    • Pipelines Sprint Pioneers 25, Pipelines Sprint Pioneers 26, Pipelines Sprint Pioneers 27, Pipelines Sprint Pioneers 28, Pipelines Sprint Pioneers 29

      If enforcedConfigLevel set to `namespace` as shown below,

      apiVersion: v1
      data:
        global-config: |-
          enforcedConfigLevel: namespace
          ttlSecondsAfterFinished: 60
          historyLimit: 2
          namespaces:
            demo:
              ttlSecondsAfterFinished: 120
              historyLimit: 3
      kind: ConfigMap
      metadata:
        name: tekton-pruner-default-spec
        namespace: tekton-pipelines

      PipelineRuns and TaskRuns created in namespaces other than `demo` namespace as mentioned in this case should inherit the config settings from global. For example a PR created in default namespace should be deleted 60 seconds after completion and all PRs in default namespace should watch for limit of 2 (success and failure each 2)

      The bug is that existing logic does not fallthrough to global if namespace specs are not specified, hence the PRs and TRs corresponding to any namespace which do have any explicit setting definition for the namespace are not pruned if the enforced configlevel is namespace.

              rh-ee-anataraj Anitha Natarajan
              rh-ee-anataraj Anitha Natarajan
              Sri Vignesh Selvan Sri Vignesh Selvan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: