Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-7680

PaC incorrectly blocking pull requests when source doesn't have .tekton dir

XMLWordPrintable

    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide
      Before this update, when an unauthorized user opened a pull request and the target branch (e.g. main) did not contain a .tekton directory, Pipelines as Code (PaC) would create a pending check while waiting for a repository admin to approve the CI run via the /ok-to-test command. However, after the admin approved the PR, the pending check remained indefinitely, blocking auto-merge.

      This is solved by ensuring that the check is properly updated after approval, allowing auto-merge to proceed as expected.
      Show
      Before this update, when an unauthorized user opened a pull request and the target branch (e.g. main) did not contain a .tekton directory, Pipelines as Code (PaC) would create a pending check while waiting for a repository admin to approve the CI run via the /ok-to-test command. However, after the admin approved the PR, the pending check remained indefinitely, blocking auto-merge. This is solved by ensuring that the check is properly updated after approval, allowing auto-merge to proceed as expected.
    • Bug Fix
    • Done
    • Pipelines Sprint Crookshank 33, Pipelines Sprint Crookshank 34

      Hello, making this ticket as a result of this slack thread - https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1747934428582659?thread_ts=1747208624.699039&cid=C04PZ7H0VA8

      As far as I can understand, the issue is:

      1. the odh-dashboard repo is onboarded into konflux (i.e. the konflux app is integrated with the repo)
      2. the only branch that has a konflux component associated with it (and has a .tekton folder) is the "konflux-poc" branch
      3. The main branch does not have a .tekton folder
      4. external collaborators are submitting PRs into the main branch, and the konflux app blocks merges, saying it needs an "/ok-to-test" from a maintainer. This should not  be happening because main doesn't even have a .tekton folder
      5. Even when maintainer comments '/ok-to-test', the konflux app does not unnblock the PR.

       

              rh-ee-zashaikh Zaki Shaikh
              rh-ee-ckodama Christopher Kodama (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: