Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-7112

Avoid creating a Pending Check when unauthorize user issue gitops command rem-ok-to-test is false

XMLWordPrintable

    • 3
    • False
    • Hide

      None

      Show
      None
    • False

      Story (Required)

      As a repository administrator trying to manage CI triggers in PRs, I want PaC to handle unauthorized requests for /retest or /test <test> without creating a pending check when `remember-ok-to-test` is false.

       

      Slack thread: https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1739199559422649

      Background (Required)

      The goal is to improve the CI/CD workflow by preventing unnecessary pending checks that block auto-merging of PRs. This enhancement will streamline the pull request process and reduce manual interventions, thereby improving the developer experience.

      Out of scope

      • Changes to the behavior when ok-to-test is true.
      • Modifications to other CI/CD tools or integrations beyond PaC.

      Approach (Required)

      1. Investigate Current Behavior:
        • Validate that the pending check is indeed created due to ok-to-test being false.
      1. Modify PaC Configuration:
        • Update PaC settings to ignore unauthorized requests for /retest or /test <test> when ok-to-test is false.
        • Implement a mechanism to add a comment to the PR instead of creating a pending check.
        •  
      1. Testing:
        • Test the new behavior in various scenarios to ensure it works as expected without disrupting other functionalities.

      Dependencies

      <Describes what this story depends on. Dependent Stories and EPICs should be linked to the story.>

      Acceptance Criteria (Mandatory)

      <Describe edge cases to consider when implementing the story and defining tests>

      <Provides a required and minimum list of acceptance tests for this story. More is expected as the engineer implements this story>

      INVEST Checklist

      Dependencies identified

      Blockers noted and expected delivery timelines set

      Design is implementable

      Acceptance criteria agreed upon

      Story estimated

      Legend

      Unknown

      Verified

      Unsatisfied

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

              rh-ee-zashaikh Zaki Shaikh
              cboudjna@redhat.com Chmouel Boudjnah
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: