Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-7046

Even with a finalizer, pruner deletes a PR if the global config is set for `ttlSecondsAfterFinished`

XMLWordPrintable

      Description of problem:

      Pruner should bot delete a PipelineRun or TaskRun if there is a finalizer set. This behavior is breached if we set the configmap as below:

      apiVersion: v1kind: ConfigMapmetadata:  name: tekton-pruner-default-spec  namespace: tekton-pipelinesdata:  global-config: |    ttlSecondsAfterFinished: 180 

      Prerequisites (if any, like setup, operators/versions):

      Install pipelines, PAC and pruner on a local kind cluster

      Edit the defualt pruner configmap "tekton-pruner-default-spec" in "tekton-pipelines" namespace as below * *

      apiVersion: v1kind: ConfigMapmetadata:  name: tekton-pruner-default-spec  namespace: tekton-pipelinesdata:  global-config: |    ttlSecondsAfterFinished: 180 

      Steps to Reproduce

       Trigger events in repository that creates PAC PRs

      Actual results:

      All PRs that have reached the terminal state are pruned after the defined time limit.

      Expected results:

      PAC originated PRs have finalizer set and hence pruner should not delete those PRs. This works as expected if the pruner configmap includes settings only for history limiter whereas even with a pac finalizer if the config is based on ttl seconds the PR gets deleted, which might create issues if the PR is not yet processed by Chains or results.

      Reproducibility (Always/Intermittent/Only Once):

      Acceptance criteria: 

       

      Definition of Done:

      Build Details:

      Additional info (Such as Logs, Screenshots, etc):

       

       *

              Unassigned Unassigned
              rh-ee-anataraj Anitha Natarajan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: