-
Bug
-
Resolution: Unresolved
-
Major
-
Pipelines 1.15.0
-
False
-
None
-
False
-
Fixed skopeo-copy task to support copying multiple images using url.txt file.
-
Bug Fix
-
Proposed
-
-
Downstream tracker of the GH Issue.
Description of problem:
I am trying to use provided Tasks + cluster resolver instead of ClusterTasks and found one discrepancy between skopeo-copy ClusterTask and the newly-provided Task.
We use skopeo-copy task to copy image under more than one destination image URLs, so we utilize images_url workspace and url.txt file on it. In the ClusterTask, parameter source image URL and destination image URL were optional, i.e. they had default value of an empty string, so if they were not filled, the task would use the url.txt file method. But in the new Task they have no default value. This means they have to be filled, at least with an empty string. This, however, means that the exported_or_fail() function:
in the common.sh script makes the task fail because it requires source and destination image urls to be non-empty. It checks using the -z test option:
On the other hand, if we fill in a non-empty string, the task will bypass the url.txt file.
I think the fix would be to mark the source and destination parameters as optional by providing default value "" to them and by removing these params from the following call:
Support for the task was seemingly added by #83 but due to the mentioned issue it has probably never worked.{}
Steps to Reproduce
Try to provide empty Source & Destination image, the task will fail, making it unable to use the url.txt file to copy multiple images at once.
Actual results:
Multiple images cannot be copied at once.
Expected results:
Multiple images can be copied by providing a url.txt file.
Reproducibility (Always/Intermittent/Only Once):
Always.
Acceptance criteria:
Multiple images can be copied at once.
Definition of Done:
Pull request with the fix and test is merged in the task-containers repository.
Build Details:
N/A
Additional info (Such as Logs, Screenshots, etc):
N/A