Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-5571

setting pipelinerun_provenance for both global and namespaced repository creating panic

XMLWordPrintable

    • 1
    • False
    • None
    • False
    • 2
    • Pipelines Sprint Pioneers 9, Pipelines Sprint Pioneers 10, Pipelines Sprint Pioneers 11, Pipelines Sprint Crookshank 13

      Description of problem:

      Issue in pac controller

      ```

      {"level":"info","ts":"2024-06-17T09:05:38.164Z","logger":"pipelinesascode","caller":"events/emit.go:48","msg":"cannot locate templates in .tekton/ directory for this repository in savitaashture-patch-112","commit":"fdf40db","provider":"github","event-id":"c213b2e0-2c88-11ef-9445-e422906a09c3","event-sha":"48203eed28c3bbab917add84967ac230140601a1","event-type":"pull_request","namespace":"test-pac-pipelines"} {"level":"info","ts":"2024-06-17T09:10:15.995Z","logger":"pipelinesascode","caller":"adapter/adapter.go:140","msg":"detected global repository settings named pipelines-as-code in namespace pipelines-as-code","commit":"fdf40db"}

      panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xc6a63b] goroutine 3120 [running]: github.com/openshift-pipelines/pipelines-as-code/pkg/apis/pipelinesascode/v1alpha1.(*Settings).Merge(...) github.com/openshift-pipelines/pipelines-as-code/pkg/apis/pipelinesascode/v1alpha1/types.go:110 github.com/openshift-pipelines/pipelines-as-code/pkg/apis/pipelinesascode/v1alpha1.(*RepositorySpec).Merge(0x279b808?, {0xc0010cb388,

      {0x0, 0x0}

      , 0x0, 0x0, 0xc0004a6be8, 0xc000ec8120}) github.com/openshift-pipelines/pipelines-as-code/pkg/apis/pipelinesascode/v1alpha1/types.go:87 +0x7b github.com/openshift-pipelines/pipelines-as-code/pkg/pipelineascode.(*PacRun).verifyRepoAndUser(0xc0011a6120, {0x279b808, 0xc0005675c0}) github.com/openshift-pipelines/pipelines-as-code/pkg/pipelineascode/match.go:64 +0x165 github.com/openshift-pipelines/pipelines-as-code/pkg/pipelineascode.(*PacRun).matchRepoPR(0xc0011a6120, {0x279b808, 0xc0005675c0}) github.com/openshift-pipelines/pipelines-as-code/pkg/pipelineascode/match.go:25 +0x26 github.com/openshift-pipelines/pipelines-as-code/pkg/pipelineascode.(*PacRun).Run(0xc0011a6120, {0x279b808?, 0xc0005675c0}) github.com/openshift-pipelines/pipelines-as-code/pkg/pipelineascode/pipelineascode.go:57 +0x45 github.com/openshift-pipelines/pipelines-as-code/pkg/adapter.(*sinker).processEvent(0xc000bc1800, {0x279b808, 0xc0005675c0}, 0xc0011c0d00?) github.com/openshift-pipelines/pipelines-as-code/pkg/adapter/sinker.go:60 +0x392 github.com/openshift-pipelines/pipelines-as-code/pkg/adapter.(*listener).Start.listener.handleEvent.func2.1() github.com/openshift-pipelines/pipelines-as-code/pkg/adapter/adapter.go:194 +0x2c created by github.com/openshift-pipelines/pipelines-as-code/pkg/adapter.(*listener).Start.listener.handleEvent.func2 in goroutine 3119 github.com/openshift-pipelines/pipelines-as-code/pkg/adapter/adapter.go:193 +0x9e5

      ```

      Prerequisites (if any, like setup, operators/versions):

      Steps to Reproduce

      • Initially I did set pipelinerun_provenance for global repo
        apiVersion: pipelinesascode.tekton.dev/v1alpha1
        kind: Repository
        metadata:  
          name: pipelines-as-code  
          namespace: openshift-pipelines
        spec:  
          params:    
          - name: custom      
            value: "value"  
          settings:    
            pipelinerun_provenance: "default_branch" 
      • Sent a pullrequest
      • Then i observed above error in PAC controller

       

      Actual results:

      Expected results:

      Reproducibility (Always/Intermittent/Only Once):

      Acceptance criteria: 

       

      Definition of Done:

      Build Details:

      Additional info (Such as Logs, Screenshots, etc):

       

       *

            sashture Savita .
            sashture Savita .
            Zaki Shaikh Zaki Shaikh
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: