Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-4602

provide a cel regex PR filtering example in the PAC doc

XMLWordPrintable

    • False
    • None
    • False

      Story (Required)

      As a <PERSONA> trying to <ACTION> I want <THIS OUTCOME>

      As a user of pipelines as code trying to gate the launching of test pipelineruns for merge requests in my repository when non coding files are updated, I need a precise example from the documentation to work off of.

      <Describes high level purpose and goal for this story. Answers the questions: Who is impacted, what is it and why do we need it? How does it improve the customer’s experience?>

      Background (Required)

      <Describes the context or background related to this story>

      Several Konflux users, including asegurap1@redhat.com from the hypershift team, have been struggling crafting a cel regexp expression to avoid the launching of test pipelines when only non golang files were updated.

      His initial attempts based on the current documentation had syntax errors that were only revealed through mining of the PAC controller logs.

      I ultimately had to build a branch with a specialized test case so he could iterate on his expression and get the formatting correct.

      Out of scope

      <Defines what is not included in this story>

      Approach (Required)

      <Description of the general technical path on how to achieve the goal of the story. Include details like json schema, class definitions>

      Minimally take the example asegurap1@redhat.com crafted in https://github.com/openshift/hive/blob/a0e3905300090e1141bba9a17381f6c1a3c3522c/.tekton/hive-pull-request.yaml#L10-L13 and include that as an example in the PAC documentation at https://pipelinesascode.com/docs/guide/authoringprs/#advanced-event-matching

       

      Also reach out to him to see if he has new examples which could be useful.

      Dependencies

      <Describes what this story depends on. Dependent Stories and EPICs should be linked to the story.>

      Acceptance Criteria (Mandatory)

      <Describe edge cases to consider when implementing the story and defining tests>

      <Provides a required and minimum list of acceptance tests for this story. More is expected as the engineer implements this story>

      INVEST Checklist

      Dependencies identified

      Blockers noted and expected delivery timelines set

      Design is implementable

      Acceptance criteria agreed upon

      Story estimated

      Legend

      Unknown

      Verified

      Unsatisfied

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

              Unassigned Unassigned
              gmontero@redhat.com Gabe Montero
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated: