Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-4407

Increase pac entropy when generating random secret name

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Normal Normal
    • Pipelines 1.15.0
    • Pipelines 1.14.0
    • Pipelines as Code
    • None
    • False
    • None
    • False
    • The random secret as generate by pac with the github temporary token has now an increase of two random characters to further avoid risk of collisions when creating them

      Story (Required)

       
      From arewm upstream https://github.com/openshift-pipelines/pipelines-as-code/issues/1663

      When the auth secret names only have four characters of entropy, the likelihood of collisions is high especially when there are many concurrent events triggered within a namespace.
      At a minimum, we should increase the number of random characters in the secret name. If possible, this can be a configurable parameter during the deployment of PAC.

      Background (Required)

      <Describes the context or background related to this story>

      Out of scope

      <Defines what is not included in this story>

      Approach (Required)

      <Description of the general technical path on how to achieve the goal of the story. Include details like json schema, class definitions>

      Dependencies

      <Describes what this story depends on. Dependent Stories and EPICs should be linked to the story.>

      Acceptance Criteria (Mandatory)

      <Describe edge cases to consider when implementing the story and defining tests>

      <Provides a required and minimum list of acceptance tests for this story. More is expected as the engineer implements this story>

      INVEST Checklist

      Dependencies identified

      Blockers noted and expected delivery timelines set

      Design is implementable

      Acceptance criteria agreed upon

      Story estimated

      Legend

      Unknown

      Verified

      Unsatisfied

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

            cboudjna@redhat.com Chmouel Boudjnah
            cboudjna@redhat.com Chmouel Boudjnah
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: