Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-4348

UpdateLog calls from watcher intermittently fail with canceled context; no UpdateLog call error from watcher are re-reconciled

    XMLWordPrintable

Details

    • 5
    • False
    • None
    • False
    • Hide
      The optional storage of underlying Pod logs for PipelineRuns or TaskRuns would intermittently fail because the golang Contex used for remote procedure calls t was not properly managed in the Tekton Results Watcher. In both the Watcher and Tekton Results API Server the user would see messages about the 'UpdateLog' action failing with 'canceled context error'

      The fix for this introduced proper context coordination in the Watcher's update logs feature. This includes adding a default timeout for update log operations of 30 seconds. That default can be modified by setting in seconds the 'update_log_timeout' argument on the Watcher's deployment. For example, "60s" would change to 60 seconds.
      Show
      The optional storage of underlying Pod logs for PipelineRuns or TaskRuns would intermittently fail because the golang Contex used for remote procedure calls t was not properly managed in the Tekton Results Watcher. In both the Watcher and Tekton Results API Server the user would see messages about the 'UpdateLog' action failing with 'canceled context error' The fix for this introduced proper context coordination in the Watcher's update logs feature. This includes adding a default timeout for update log operations of 30 seconds. That default can be modified by setting in seconds the 'update_log_timeout' argument on the Watcher's deployment. For example, "60s" would change to 60 seconds.
    • Bug Fix
    • 8
    • Pipelines Sprint Pioneers 1, Pipelines Sprint Pioneers 2, Pipelines Sprint Pioneers 3

    Description

      Tracker for upstream https://github.com/tektoncd/results/issues/720 and https://github.com/tektoncd/results/pull/715 that I discovered while working the memory leak fix

       

      It also enable proper retry on errors that rh-ee-sabiswas reported to us before transferring to pipeline-integrations

       

      Attachments

        Activity

          People

            gmontero@redhat.com Gabe Montero
            gmontero@redhat.com Gabe Montero
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated: