Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-3251

PaC support for OWNERS_ALIASES files

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • Pipelines as Code
    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • Pipelines Sprint 260, Pipelines SprintCrookshanks262, Pipelines Sprint Crookshanks 3, Pipelines Sprint Crookshanks 5, Pipelines Sprint Crookshanks 7, Pipelines Sprint Crookshanks 8

      Story (Required)

      As a developer trying to use CI based on OSP and PaC I want to be able to enlist project maintainers and reviewers in OWNERS_ALIASES file.

      Background (Required)

      PaC looks into OWNERS file to verify permissions for triggering pipelinerun. The OWNERS file guide specifies that the OWNERS file functionality can be extended by putting some of the configuration into OWNERS_ALIASES file https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#owners_aliases.

      And there are some projects using that, e.g https://github.com/openshift/assisted-service/tree/master. In this case this lead by some confusion, because pipelineruns triggered on PRs and comments from people in the OWNERS_ALIASES file were actually rejected - PLNSRVCE-1365.

      Out of scope

      <Defines what is not included in this story>

      Approach (Required)

      • Check the OWNERS_ALIASES exists in the repo and read it if found
      • When verifying permissions on a pac instance, use the information from both OWNERS and OWNERS_ALIASES files
      • Add e2e tests to gitea

      Dependencies

      Acceptance Criteria (Mandatory)

      • Project maintainers listed in the OWNERS_ALIASES file should be allowed to trigger pipelineruns through PaC.

      INVEST Checklist

      Dependencies identified

      Blockers noted and expected delivery timelines set

      Design is implementable

      Acceptance criteria agreed upon

      Story estimated

      Legend

      Unknown

      Verified

      Unsatisfied

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

              enatan Emil Natan
              enatan Emil Natan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: