Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-3159

Github annotations are shown even after disabling error-detection-from-container-logs

    XMLWordPrintable

Details

    • False
    • None
    • False

    Description

      Description of problem:

      Github annotations are shown even after disabling error-detection-from-container-logs

      Prerequisites (if any, like setup, operators/versions):

      Install the latest build of Openshift Pipelines 1.11.0

      Steps to Reproduce

      1. Configure PAC
      2. Set error-detection-from-container-logs to "false" in config CR
      3. Create a pull request event where the pipelinerun fails (ref: https://github.com/rupalibehera/pac-demo/pull/4)
      4. Observe the github checks

       

      Actual results:

      Github annotations are shown

      Expected results:

      Github annotations should not be shown

      Reproducibility (Always/Intermittent/Only Once):

      Always

      Acceptance criteria: 

       

      Definition of Done:

      Build Details:

      Additional info (Such as Logs, Screenshots, etc):

      tkn version
      Client version: 0.31.0
      Chains version: v0.16.0
      Pipeline version: v0.47.1
      Triggers version: v0.24.0
      Operator version: v0.67.0
      oc get pac                                                                      
      NAME                VERSION   READY   REASON
      pipelines-as-code   v0.19.1   True    

       *

      Attachments

        Activity

          People

            piyushgarg001 Piyush Garg
            varadhya Veeresh Aradhya
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: