Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-10760

Tekton Results - fix all golangci-lint errors and warnings

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Critical Critical
    • None
    • None
    • Tekton Results
    • None
    • 2
    • False
    • Hide

      None

      Show
      None
    • False
    • Release Note Not Required
    • Upstream Only
    • Pipelines Sprint CrookShank 48

      Story (Required)

      golangci-lint was introduced to the project recently. It's configured to run on new changes only (only-new-issues: true). While this works for PR raised the "regular way" from a feature branch on a fork, it does not work for PRs raised by Dependabot as it uses shallow clone and golangci-lint can't calculate the diff of issues found between the PR and the base branch.

      We need the Dependabot updates included into the upstream release of Results, which on the other hand is needed for the 1.22 OSP release, so the issue is kind of blocker for the release.

      Background (Required)

      <Describes the context or background related to this story>

      Out of scope

      <Defines what is not included in this story>

      Approach (Required)

      <Description of the general technical path on how to achieve the goal of the story. Include details like json schema, class definitions>

      Dependencies

      <Describes what this story depends on. Dependent Stories and EPICs should be linked to the story.>

      Acceptance Criteria (Mandatory)

      <Describe edge cases to consider when implementing the story and defining tests>

      <Provides a required and minimum list of acceptance tests for this story. More is expected as the engineer implements this story>

      INVEST Checklist

      Dependencies identified

      Blockers noted and expected delivery timelines set

      Design is implementable

      Acceptance criteria agreed upon

      Story estimated

      Legend

      Unknown

      Verified

      Unsatisfied

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

              enatan Emil Natan
              enatan Emil Natan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: