-
Story
-
Resolution: Done
-
Normal
-
None
-
None
-
None
-
Pipelines Sprint CrookShank 47
Background (Required)
PAC unit tests are running slowly where a couple of them making actual network calls to the github api instead of using a mock HTTP server.
This increases the run time ofÂ
- TestReconciler_FinalizeKind to 18.8s
- TestReconcileKind_SCMReportingLogic to 9.4 seconds
Out of scope
<Defines what is not included in this story>
Approach (Required)
Add a mock HTTP server for unit tests instead of actual network calls to the github server.
Dependencies
<Describes what this story depends on. Dependent Stories and EPICs should be linked to the story.>
Acceptance Criteria (Mandatory)
<Describe edge cases to consider when implementing the story and defining tests>
<Provides a required and minimum list of acceptance tests for this story. More is expected as the engineer implements this story>
INVEST Checklist
Dependencies identified
Blockers noted and expected delivery timelines set
Design is implementable
Acceptance criteria agreed upon
Story estimated
Legend
Unknown
Verified
Unsatisfied
Done Checklist
- Code is completed, reviewed, documented and checked in
- Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
- Continuous Delivery pipeline(s) is able to proceed with new code included
- Customer facing documentation, API docs etc. are produced/updated, reviewed and published
- Acceptance criteria are met