Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-10028

resource-groups(label & annotation) based pipelineRuns are not getting pruned based on the configuration specified in configmap

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • None
    • Pipelines 1.21.0
    • Pruner

      Description of problem:

      resource-groups(label & annotation) based pipelineRuns are not getting pruned based on the configuration specified in configmap

      Prerequisites (if any, like setup, operators/versions):

      Steps to Reproduce

      1. Install 1.21 OSP
      2. Disable old pruner & enable tektonpruner
      3. Set enforcedConfigLevel from global to namespace
      4. Create test namespace for testing label & annotation level pruning
      5. Create tekton-pruner-namespace-spec with label & annotation config as below
      $ oc get cm tekton-pruner-namespace-spec -oyaml
      apiVersion: v1
      data:
        ns-config: |
          pipelineRuns:
            - selector:
              - matchLabels:
                  env: test
              successfulHistoryLimit: 2
              failedHistoryLimit: 3
      kind: ConfigMap
      metadata:
        creationTimestamp: "2025-12-29T04:15:43Z"
        labels:
          app.kubernetes.io/part-of: tekton-pruner
          pruner.tekton.dev/config-type: namespace
        name: tekton-pruner-namespace-spec
        namespace: test-label-1
        resourceVersion: "2233404"
        uid: ad0d5cf7-2438-47e9-b7b8-ca701d62028c
       
      1. Create pipelineRuns with label & annotations configured in the configmap

       

      Actual results:

      resource-groups(label & annotation) based pipelineRuns are not getting pruned based on the configuration specified in configmap

      $ opc pr ls
      NAME                                                STARTED         DURATION   STATUS
      jib-maven-run-test-label                            4 minutes ago   15s        Failed
      jib-maven-pz-run-test-label                         4 minutes ago   30s        Failed
      helm-upgrade-from-source-run-test-label             4 minutes ago   23s        Succeeded
      helm-upgrade-from-repo-run-test-label               4 minutes ago   7s         Succeeded
      git-clone-stepaction-run-test-label                 4 minutes ago   0s         Failed(CouldntGetTask)
      git-clone-read-private-pipeline-run-test-label      4 minutes ago   8s         Failed
      git-clone-read-private-pipeline-sa-run-test-label   4 minutes ago   0s         Failed
      git-cli-test-label-run                              5 minutes ago   19s        Succeeded
      git-cli-read-private-run-test-label                 5 minutes ago   16s        Failed
      buildah-run-test-label                              5 minutes ago   35s        Succeeded
      buildah-ns-run-test-label                           5 minutes ago   44s        Succeeded 
      $ oc get po --show-labels | grep "env=test"
      buildah-ns-run-test-label-clone-git-repo-pod                      0/1     Completed   0          8m22s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.4.1,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=buildah-ns-pipeline,tekton.dev/pipelineRun=buildah-ns-run-test-label,tekton.dev/pipelineRunUID=37266824-1e52-4dc2-bb00-21e24a78f1ed,tekton.dev/pipelineTask=clone-git-repo,tekton.dev/task=git-clone,tekton.dev/taskRun=buildah-ns-run-test-label-clone-git-repo,tekton.dev/taskRunUID=1f89ca8d-c787-4159-84c8-65b8a0b04d04
      buildah-ns-run-test-label-run-buildah-pod                         0/1     Completed   0          8m5s    app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.8.0,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=buildah-ns-pipeline,tekton.dev/pipelineRun=buildah-ns-run-test-label,tekton.dev/pipelineRunUID=37266824-1e52-4dc2-bb00-21e24a78f1ed,tekton.dev/pipelineTask=run-buildah,tekton.dev/task=buildah-ns,tekton.dev/taskRun=buildah-ns-run-test-label-run-buildah,tekton.dev/taskRunUID=b8517217-4fb6-41c7-9ebf-4bc73493a3b6
      buildah-run-test-label-clone-git-repo-pod                         0/1     Completed   0          8m18s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.4.1,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=buildah-pipeline,tekton.dev/pipelineRun=buildah-run-test-label,tekton.dev/pipelineRunUID=b3d96425-e69e-4120-8764-6320ce383594,tekton.dev/pipelineTask=clone-git-repo,tekton.dev/task=git-clone,tekton.dev/taskRun=buildah-run-test-label-clone-git-repo,tekton.dev/taskRunUID=ef80fed5-51c1-42d3-a93f-21a4653ff3e6
      buildah-run-test-label-run-buildah-pod                            0/1     Completed   0          8m7s    app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.8.0,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=buildah-pipeline,tekton.dev/pipelineRun=buildah-run-test-label,tekton.dev/pipelineRunUID=b3d96425-e69e-4120-8764-6320ce383594,tekton.dev/pipelineTask=run-buildah,tekton.dev/task=buildah,tekton.dev/taskRun=buildah-run-test-label-run-buildah,tekton.dev/taskRunUID=debfdc4a-da33-4140-ac26-e67b9d26e79a
      git-cli-read-private-run-test-label-git-cli-pod                   0/1     Error       0          8m4s    app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.4.1,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=git-cli-read-private-pipeline,tekton.dev/pipelineRun=git-cli-read-private-run-test-label,tekton.dev/pipelineRunUID=d54372ce-d429-4eed-b430-ad5a817944b2,tekton.dev/pipelineTask=git-cli,tekton.dev/task=git-cli,tekton.dev/taskRun=git-cli-read-private-run-test-label-git-cli,tekton.dev/taskRunUID=ee27e40b-55ca-41eb-8dbe-2cfa6a08abca
      git-cli-test-label-run-clone-git-repo-pod                         0/1     Completed   0          7m56s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.4.1,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=git-cli-pipeline,tekton.dev/pipelineRun=git-cli-test-label-run,tekton.dev/pipelineRunUID=8c33f82d-9c07-4b45-90da-b96e21c7273d,tekton.dev/pipelineTask=clone-git-repo,tekton.dev/task=git-clone,tekton.dev/taskRun=git-cli-test-label-run-clone-git-repo,tekton.dev/taskRunUID=47b33f87-35f2-471d-940d-f13c7c814431
      git-cli-test-label-run-git-cli-pod                                0/1     Completed   0          7m45s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.4.1,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=git-cli-pipeline,tekton.dev/pipelineRun=git-cli-test-label-run,tekton.dev/pipelineRunUID=8c33f82d-9c07-4b45-90da-b96e21c7273d,tekton.dev/pipelineTask=git-cli,tekton.dev/task=git-cli,tekton.dev/taskRun=git-cli-test-label-run-git-cli,tekton.dev/taskRunUID=68a48179-d86b-4b20-ae84-c77cf790978f
      git-clone-read-private-pipeline-run-test-label-git-clone-pod      0/1     Error       0          7m47s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.4.1,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=git-clone-read-private-pipeline,tekton.dev/pipelineRun=git-clone-read-private-pipeline-run-test-label,tekton.dev/pipelineRunUID=a3b68713-ae06-45dd-8a31-3ea89e470a67,tekton.dev/pipelineTask=git-clone,tekton.dev/task=git-clone,tekton.dev/taskRun=git-clone-read-private-pipeline-run-test-label-git-clone,tekton.dev/taskRunUID=86abe38a-59a4-4cd6-845b-0e2320c945d1
      helm-u6ee365fadfac52f757f98886de96cef2d26d8eabbc2612e3fcc81-pod   0/1     Completed   0          7m15s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.3,env=test,operator.tekton.dev/provider-type=community,tekton.dev/memberOf=tasks,tekton.dev/pipeline=helm-upgrade-from-source,tekton.dev/pipelineRun=helm-upgrade-from-source-run-test-label,tekton.dev/pipelineRunUID=6455cac6-86f8-4b6d-916b-4f2aa06c31be,tekton.dev/pipelineTask=helm-upgrade-from-source,tekton.dev/task=helm-upgrade-from-source,tekton.dev/taskRun=helm-u6ee365fadfac52f757f98600114f5f72-helm-upgrade-from-source,tekton.dev/taskRunUID=8f1e3099-16f8-42d2-9895-97502d341646
      helm-upgrade-from-repo-run-082a9a44cd763bb4724551f0ef6dcb99-pod   0/1     Completed   0          7m35s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.2,env=test,operator.tekton.dev/provider-type=community,tekton.dev/memberOf=tasks,tekton.dev/pipeline=helm-upgrade-from-repo,tekton.dev/pipelineRun=helm-upgrade-from-repo-run-test-label,tekton.dev/pipelineRunUID=c1f04c3a-3c4d-49c1-b4ac-436d5d7f9110,tekton.dev/pipelineTask=helm-upgrade-from-repo,tekton.dev/task=helm-upgrade-from-repo,tekton.dev/taskRun=helm-upgrade-from-repo-run-test-label-helm-upgrade-from-repo,tekton.dev/taskRunUID=c5a05643-4447-4ef4-92eb-fbdc05c36b4e
      helm-upgrade-from-source-run-test-label-clone-git-repo-pod        0/1     Completed   0          7m29s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.4.1,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=helm-upgrade-from-source,tekton.dev/pipelineRun=helm-upgrade-from-source-run-test-label,tekton.dev/pipelineRunUID=6455cac6-86f8-4b6d-916b-4f2aa06c31be,tekton.dev/pipelineTask=clone-git-repo,tekton.dev/task=git-clone,tekton.dev/taskRun=helm-upgrade-from-source-run-test-label-clone-git-repo,tekton.dev/taskRunUID=c6c31829-4291-40fb-9932-27d4cdff17d2
      jib-maven-pz-run-test-label-build-pod                             0/2     Error       0          7m13s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.5,env=test,operator.tekton.dev/provider-type=community,tekton.dev/memberOf=tasks,tekton.dev/pipeline=jib-maven-pipeline,tekton.dev/pipelineRun=jib-maven-pz-run-test-label,tekton.dev/pipelineRunUID=85280ef5-b124-4a2d-ae24-02c38778ef1e,tekton.dev/pipelineTask=build,tekton.dev/task=jib-maven,tekton.dev/taskRun=jib-maven-pz-run-test-label-build,tekton.dev/taskRunUID=bcb4f512-faa4-4c66-a4b6-274d5e8ad564
      jib-maven-pz-run-test-label-clone-git-repo-pod                    0/1     Completed   0          7m22s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.4.1,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=jib-maven-pipeline,tekton.dev/pipelineRun=jib-maven-pz-run-test-label,tekton.dev/pipelineRunUID=85280ef5-b124-4a2d-ae24-02c38778ef1e,tekton.dev/pipelineTask=clone-git-repo,tekton.dev/task=git-clone,tekton.dev/taskRun=jib-maven-pz-run-test-label-clone-git-repo,tekton.dev/taskRunUID=e37d16ae-6426-4a2e-acf4-04c6251fd413
      jib-maven-run-test-label-build-pod                                0/2     Error       0          7m9s    app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.5,env=test,operator.tekton.dev/provider-type=community,tekton.dev/memberOf=tasks,tekton.dev/pipeline=jib-maven-pipeline,tekton.dev/pipelineRun=jib-maven-run-test-label,tekton.dev/pipelineRunUID=993b8013-771e-46df-8281-9819c71253b1,tekton.dev/pipelineTask=build,tekton.dev/task=jib-maven,tekton.dev/taskRun=jib-maven-run-test-label-build,tekton.dev/taskRunUID=f1dc0ba6-eaa6-4200-b2d7-44feae293e99
      jib-maven-run-test-label-clone-git-repo-pod                       0/1     Completed   0          7m18s   app.kubernetes.io/managed-by=tekton-pipelines,app.kubernetes.io/version=0.4.1,env=test,operator.tekton.dev/operand-name=openshift-pipelines-addons,operator.tekton.dev/provider-type=redhat,tekton.dev/memberOf=tasks,tekton.dev/pipeline=jib-maven-pipeline,tekton.dev/pipelineRun=jib-maven-run-test-label,tekton.dev/pipelineRunUID=993b8013-771e-46df-8281-9819c71253b1,tekton.dev/pipelineTask=clone-git-repo,tekton.dev/task=git-clone,tekton.dev/taskRun=jib-maven-run-test-label-clone-git-repo,tekton.dev/taskRunUID=15b85541-261c-4464-8500-5cfe1272d252 

      Expected results:

      Resource groups based (label & annotation) pipelineRuns should get pruned based on the configuration set in configmap

      Reproducibility (Always/Intermittent/Only Once):

      Acceptance criteria: 

       

      Definition of Done:

      Build Details:

      Additional info (Such as Logs, Screenshots, etc):

      PFA logs for reference
      tekton-pruner-controller-logs.log
      tekton-pruner-webhook-logs.log label-ns-spec.yaml
      prune-annotations-cm.yaml
      buildah-label-pipelineRun.yaml
      tkn-annotation-pipelineRun.yaml
      tektonconfig.yaml

       *

        1. buildah.yaml
          0.3 kB
        2. buildah-label-pipelineRun.yaml
          0.3 kB
        3. label-ns-spec.yaml
          0.4 kB
        4. prune-annotations-cm.yaml
          0.4 kB
        5. tektonconfig.yaml
          6 kB
        6. tekton-pruner-controller-logs.log
          724 kB
        7. tekton-pruner-webhook-logs.log
          32 kB
        8. tkn-annotation-pipelineRun.yaml
          0.6 kB

              rh-ee-shubbhar Shubham Bhardwaj
              rh-ee-smanthin Sai Raju Manthina
              Shubham Bhardwaj
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: