Uploaded image for project: 'OpenShift Specialist Platform Team'
  1. OpenShift Specialist Platform Team
  2. SPLAT-2518

update installer to no longer use deprecated controller-runtime interfaces (validator/defaulter)

    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • 3
    • 3
    • None
    • OpenShift SPLAT - Sprint 277, OpenShift SPLAT - Sprint 278

      User Story:
      As an OpenShift Engineer I want update installer to no longer use deprecated controller-runtime interfaces (validator/defaulter) so I can migrate capi versions.

      Description:
      While attempting to upgrade the capi providers, there seems to be a dependency pinned to controller-runtime 0.19.3.  That is a very old version (latest is 0.23).  In 0.20, the defaulter/validator interface was removed (it was deprecated ages before this).  This is preventing upgrade of this component.

      # github.com/openshift/installer/pkg/asset/manifests/azure/stack/v1beta1
      pkg/asset/manifests/azure/stack/v1beta1/azurecluster_webhook.go:41:15: undefined: webhook.Validator
      pkg/asset/manifests/azure/stack/v1beta1/azurecluster_webhook.go:42:15: undefined: webhook.Defaulter
      pkg/asset/manifests/azure/stack/v1beta1/azureclusteridentity_webhook.go:38:15: undefined: webhook.Validator
      pkg/asset/manifests/azure/stack/v1beta1/azureclustertemplate_webhook.go:43:15: undefined: webhook.Defaulter
      pkg/asset/manifests/azure/stack/v1beta1/azureclustertemplate_webhook.go:50:15: undefined: webhook.Validator
      pkg/asset/manifests/azure/stack/v1beta1/azuremanagedcluster_webhook.go:35:15: undefined: webhook.Validator
      pkg/asset/manifests/azure/stack/v1beta1/azuremanagedclustertemplate_webhook.go:35:15: undefined: webhook.Validator
      

       

      Acceptance Criteria:
      The errors are resolved

      Other Information:
      < Record anything else that may be helpful to someone else picking up the card >

      issue created by splat-bot

              rhn-support-ngirard Neil Girard
              rhn-support-ngirard Neil Girard
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: