Uploaded image for project: 'ShrinkWrap Resolvers'
  1. ShrinkWrap Resolvers
  2. SHRINKRES-63

Refactor "offline" feature placement in the API

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Done
    • Icon: Major Major
    • 2.0.0-alpha-5
    • 2.0.0-alpha-2
    • None
    • None

      From Karel:

      The location of offline() method in MavenStrategyStage unfortunately does not cover all possible use cases:
      Imagine the following:
      User loads a pom - now the first resolution happens, because an effective pom is created and this is later used to define the dependencies:

      final File[] longhand = Resolvers.use(MavenResolverSystem.class).configureFromPom("path/to/pom").resolve("G:A").offline()
                  .withTransitivity().as(File.class);

      I don't think that delaying ".configureFromPom("path/to/pom").resolve("G:A")" call until MavenStrategyStage is reached in the right way to go, because that way we couldn't for instance cache already parsed POM file.

              mmatloka Michal Matloka (Inactive)
              arubinge@redhat.com Andrew Rubinger (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: