Uploaded image for project: 'ShrinkWrap Resolvers'
  1. ShrinkWrap Resolvers
  2. SHRINKRES-299

ClasspathWorkspaceReader does not support "Maven CI Friendly Versions" (e.g. ${revision})

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 3.1.4
    • 3.1.3
    • maven
    • None

    Description

      Maven 3.5.0 introduced Maven CI Friendly Versions.

      A version element with such a setup can look like this:

      <version>${revision}</version>
      

      Via debugging I found out that ClasspathWorkspaceReader will never be able to match a given artifact (which contains the interpolated, final version) with the respective workspace/classpath entry because in ClasspathWorkspaceReader.createFoundArtifact(File) it just loads the XML document, without any interpolation or even parent lookup.

      This issuse is very similar to SHRINKRES-223. Nevertheless, I saw/see two reasons for a separate issue:

      • I am not sure that the setup in SHRINKRES-223 is even officially supported by Maven (in contrast to "CI Friendly Versions")
      • I will come up with a PR that re-uses .flattened-pom.xml (created by flatten-maven-plugin, see "Install / Deploy" part on the "CI Friendly Versions" page) and that will be of no use for SHRINKRES-223

      Attachments

        Activity

          People

            Unassigned Unassigned
            falko.modler@t-systems.com Falko Modler (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: