Uploaded image for project: 'PicketBox '
  1. PicketBox
  2. SECURITY-786

Improve Memory Performance when Audit Logging is Off

XMLWordPrintable

    • Icon: Patch Patch
    • Resolution: Done
    • Icon: Major Major
    • PicketBox_4_9_0.Beta1
    • None
    • JBossSX
    • None

      We did some profiling of or JBoss AS instance and noticed that audit logging on JavaEE resources is causing most of our allocations outside TLABs. This was a bit surprising to use since we don't have audit logging on. We tracked them down to org.jboss.security.javaee.AbstractJavaEEHelper.authorizationAudit(String, Resource, Exception) which unnecessarily does an eager string conversion of every org.jboss.security.authorization.Resource. This could be done lazily on demand when audit logging is on in AuditEvent#toString. Since the map is already of type Map<String,Object> simply removing the call to #toString() fixes this.

            sguilhen Stefan Guilhen
            pmarscha Philippe Marschall
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: