Uploaded image for project: 'Spring Boot & Cloud'
  1. Spring Boot & Cloud
  2. SB-556

Support of Tomcat 8.0 & Tomcat 8.5 for SB 1.5

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Done
    • Icon: Major Major
    • None
    • 1.5.10.SP3
    • spring-boot
    • None

      Cross Product doc : https://docs.google.com/document/d/1KL3Ys-YPoPZkiBY6o_jZuflFyRzHORMB29Mevd67Zt4

      On Thu, Mar 22, 2018 at 11:05 AM, Hiram Chirino <hchirino@redhat.com> wrote:

      "The RHOAR folks might know better than me, but it could be possible that even if they use Tomcat 8.5 to build, they might be runtime compatible with 8.0 if they avoid taking code paths that use the 8.5 methods. Not sure how they validate/test the compatibility with 8.0."

      On Thu, Mar 22, 2018 at 11:00 AM, Coty Sutherland <csutherl@redhat.com> wrote:
      There is conversation occurring on the jira from the JWS side

      In summary, SB does not appear to be able to support building SB with Tomcat 8.0 (or anything other than 8.5, it appears). Their classes depend in Tomcat 8.5 classes at compile time, meaning that you can't build without them. We think that this is a bug because their docs say that it's supported. We also tried patching our Tomcat 9 to add back the missing methods, which resulted in successful compilation but failed unit tests. We think that this is due to Connector refactoring done in Tomcat 9 which is much to complex to backport/workaround in our version. Having SB resolve the Tomcat 8.0 issue appears to be the best option.

      Issue for the compatibility problems found by JWS team with Tomcat and SB 1.5 is reported here :
      https://issues.jboss.org/browse/JWS-951

      Scenario to be used to test compatibility issue : It's a set of 4 command to run the SB build and tests against any combination of SB and Tomcat. It should be really easy to add to any QE tests suite. You do it like:

      git clone https://github.com/spring-projects/spring-boot.git
      cd spring-boot
      git checkout v1.5.9.RELEASE
      mvn clean install -Dtomcat.version=8.0.36.redhat-24
      

      From Hiram: "I hope you guys can use this to make either Tomcat 8.0 or 9.0 compatible with SB 1.5."

            cmoullia Charles Moulliard
            cmoullia Charles Moulliard
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: