Uploaded image for project: 'Container Tools'
  1. Container Tools
  2. RUN-3434

[containers/conmon] Missing "<timestamp> stdout F" in container log if container terminates without writing a linebreak

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • conmon
    • 2
    • False
    • Hide

      None

      Show
      None
    • False

      [843971192] Upstream Reporter: Sergey Yedrikov
      Upstream issue status: Closed
      Upstream description:

      Issue

      conmon generates a partial log sequence not conforming to the CRI log spec (https://github.com/kubernetes/community/blob/master/contributors/design-proposals/node/kubelet-cri-logging.md) if container writes a sequence of characters into stdout/stderr and terminates without writing a newline.

      Versions

      Fedora 33
      
      $ podman version
      Version:      3.0.1
      API Version:  3.0.0
      Go Version:   go1.15.8
      Built:        Fri Feb 19 11:56:17 2021
      OS/Arch:      linux/amd64
      
      $ conmon --version
      conmon version 2.0.26
      commit: 777074ecdb5e883b9bec233f3630c5e7fa37d521
      

      How to reproduce

      $ podman run busybox /bin/sh -c "echo blah | tr 'n' ' '"

      Describe the results you received:

      Hunt down the log for the container you just ran

      
      

      $ cat ~/.local/share/containers/storage/overlay-containers/0b0250256ed0e2d675ef8ac4299aa53b20d6000a9aad25577d9e4bb210bfbb1b/userdata/ctr.log
      2021-03-29T21:16:20.753110058-04:00 stdout P blah
      ${noformat}
      Describe the results you expected: 2021-03-29T21:16:20.753110058-04:00 stdout P blah 2021-03-29T21:16:20.753110059-04:00 stdout F

      I believe the actual behavior doesn't follow the CRI log spec and conmon should be writing out a terminating F-sequence into the log if it sees a container pipe closing without a trailing newline.


      Upstream URL: https://github.com/containers/conmon/issues/252

              rhn-support-jnovy Jindrich Novy
              upstream-sync Upstream Sync
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: