Uploaded image for project: 'Container Tools'
  1. Container Tools
  2. RUN-3401

[containers/conmon] Improve --log-size-max handling

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • conmon
    • False
    • Hide

      None

      Show
      None
    • False
    • rhel-container-tools

      [715524263] Upstream Reporter: Daniel J Walsh
      Upstream issue status: Closed
      Upstream description:

      Currently conmon just truncates the log file when max is reached, this means we loose all of the data.

      I think we should allow for a backup file. So when log-size-max is reached we rename the existing file to a .1 version. Now when the user reads the full log file they would read the .1 file first and then the main log file. This would mean we would always have log-size-max data available, after we fill it up. If .1 already existed, we would loose that data.

      Since user asked for log-size-max, we should probably do the rename at log-size-max/2 to grant their wishes.

      @haircommander @giuseppe @vrothberg @mheon WDYT?


      Upstream URL: https://github.com/containers/conmon/issues/211

              rhn-support-jnovy Jindrich Novy
              upstream-sync Upstream Sync
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: