[2712821114] Upstream Reporter: Mario Loriedo
Upstream issue status: Closed
Upstream description:

Issue Description

This change introduced in 5.3.1 to the ForceReboot action in the InstallExecuteSequence

Unable to find source-code formatter for language: diff. Available languages are: actionscript, ada, applescript, bash, c, c#, c++, cpp, css, erlang, go, groovy, haskell, html, java, javascript, js, json, lua, none, nyan, objc, perl, php, python, r, rainbow, ruby, scala, sh, sql, swift, visualbasic, xml, yaml

<InstallExecuteSequence>
--    <ForceReboot Before="StopServices" Condition="(NOT Installed) AND ...
++    <ForceReboot Before="StopServices" Condition="(NOT WIX_UPGRADE_DETECTED) AND (NOT BURNMSIUNINSTALL) AND ... 
</InstallExecuteSequence>

has avoided triggering a reboot when upgrading from 5.3.0 to 5.3.1. However, the reboot will be initiated in future releases when upgrading from 5.3.1.

Adding back the condition (NOT Installed) fixes the problem for future releases. But it doesn't help if a user has already installed 5.3.1.

When upgrading from 5.3.1 to a new version, current bundle features are uninstalled, and the reboot is triggered:

Unable to find source-code formatter for language: log. Available languages are: actionscript, ada, applescript, bash, c, c#, c++, cpp, css, erlang, go, groovy, haskell, html, java, javascript, js, json, lua, none, nyan, objc, perl, php, python, r, rainbow, ruby, scala, sh, sql, swift, visualbasic, xml, yaml

MSI (s) (84:38) [19:05:24:587]: Doing action: UnpublishFeatures
Action ended 19:05:24: ProcessComponents. Return value 1.
Action start 19:05:24: UnpublishFeatures.
MSI (s) (84:38) [19:05:24:589]: Doing action: ForceReboot
Action ended 19:05:24: UnpublishFeatures. Return value 1.
Action start 19:05:24: ForceReboot.
...

Note that when the installer is run in non-interactive mode using .podman-5.4.0-dev-setup.exe /install /quiet the reboot happens automatically, without any user prompt. And that's how podman desktop, winget, scoop etc...install Podman

There are a few things that need to be investigated:

• ☐ Can the next release installer avoid the 5.3.1 installer forcing a reboot? Related discussion in WiX forum and PR to fix it.
• ☐ How can WSL_INSTALL=1 be true in the ForceReboot condition if WITH_WSL is set to zero? Is that because ForceReboot condition is evaluated before <SetProperty Id="WSL_INSTALL"...?
• ☐ Why isn't the reboot triggered when Hyper-V isn't installed? Does the CheckHyperV always set HAS_HYPERVFEATURE to true, even if vmms is not installed?
• ☐ Add automated tests to verify upgrades from main branch version to a future version (that we would have helped identify the problem earlier)
• ☐ This problem was first spotted on PR checks after 5.3.1 release. But isn't WSL pre-installed on the VM where these tests run?

Steps to reproduce the issue

Steps to reproduce the issue

1. Uninstall WSL if it's locally installed
2. Install Podman version 5.3.1
3. Build the installer from main branch (run .winmake.ps1 podman; .winmake.ps1 win-gvproxy; .winmake.ps1 docs; .winmake.ps1 installer)
4. Update Podman (run .contribwin-installerpodman-5.4.0-dev-setup.exe /install /log podman-installer.log)