Uploaded image for project: 'Container Tools'
  1. Container Tools
  2. RUN-2260

[containers/storage] pkg/chunked/GetDiffer must differentiate between failures and errors that can be ignored

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • c/storage
    • 3
    • False
    • None
    • False
    • rhel-sst-container-tools
    • 3
    • RUN 260, RUN 261

      [2552571412] Upstream Reporter: Giuseppe Scrivano
      Upstream issue status: Open
      Upstream description:

      we currently do not differentiate between critical errors (hard failures) and ignorable errors, so that the caller (containers/image in our case) can fallback to using the traditional pull code path.

      Especially with composefs and fs-verity, if any error happens in this phase, the entire pull operation must fail and containers/image must not attempt any fallback.

      Suggestion: define a new error typefor the errors that can be ignored and treat anything else as an hard failure, so that the caller can differentiate between them.


      Upstream URL: https://github.com/containers/storage/issues/2115

              gscrivan@redhat.com Giuseppe Scrivano
              upstream-sync Upstream Sync
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - 3 days Original Estimate - 3 days
                  3d
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 week
                  1w