Uploaded image for project: 'Container Tools'
  1. Container Tools
  2. RUN-2152

[containers/storage] Unreachable code in storage/drivers/overlay/overlay.go

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • c/storage
    • False
    • None
    • False
    • rhel-sst-container-tools

      [2257115478] Upstream Reporter: Erik Sjölund
      Upstream issue status: Closed
      Upstream description:

      Could this if statement be removed?

      https://github.com/containers/storage/blob/2431799327396be3322f440a56567d1d4df733e7/drivers/overlay/overlay.go#L1503-L1506

      It seems that permsKnown already needs to be true, because otherwise the for loop would have been skipped.

      Here is the relevant code:

      https://github.com/containers/storage/blob/2431799327396be3322f440a56567d1d4df733e7/drivers/overlay/overlay.go#L1495-L1507

      The code originates from the PR


      Upstream URL: https://github.com/containers/storage/issues/1900

              Unassigned Unassigned
              upstream-sync Upstream Sync
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: