• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Critical Critical
    • None
    • None
    • OpenShift Operator
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • False

      Overview:

      The WithSelector functionality is critical for correct operation of the ACS operator in the cloud service.

      As described in this PR, the current test for it in operator-framework upstream is not helpful (i.e. does not actually test anything - the test still passes if the WithSelector() call is commented out). Separate manual testing has shown the code works as expected (modulo the corner case to be fixed by the aforementioned PR) but this is nonetheless somewhat concerning.

      We are currently using a different implementation of WithSelector, but will start using the upstream one on the test rebase of our fork. So it would be good to fix this test before then.

      cc rh-ee-akurlov 

      Acceptance Criteria:

      We should change it to a test that actually exercises the Watch() that the selector affects. Probably something like this test does.

              rh-ee-akurlov Aleksandr Kurlov
              mowsiany@redhat.com Marcin Owsiany
              ACS Cloud Service
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: