Uploaded image for project: 'Red Hat Advanced Cluster Security'
  1. Red Hat Advanced Cluster Security
  2. ROX-28253 Optimize memory allocations in DB flows
  3. ROX-28998

cleanup Store interface with variadic args

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • Rox Sprint 4.8G - Global

      In Stores we have following methods

      Upsert(ctx context.Context, obj *storeType) error
UpsertMany(ctx context.Context, objs []*storeType) error
Delete(ctx context.Context, id string) error
DeleteMany(ctx context.Context, identifiers []string) error
Get(ctx context.Context, id string) (*storeType, bool, error)
GetByIDs(ctx context.Context, identifiers []string) ([]*storeType, error)

      it's possible to have a smaller interface by using variadic args

      Upsert(ctx context.Context, objs... *storeType) error
Delete(ctx context.Context, identifiers... string) error
Get(ctx context.Context, identifiers... string) ([]*storeType, error)

      https://github.com/stackrox/stackrox/pull/14974#discussion_r2044411911

              Unassigned Unassigned
              tjanisze@redhat.com Tomasz Janiszewski
              ACS Sensor & Ecosystem
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: