Uploaded image for project: 'RH-SSO'
  1. RH-SSO
  2. RHSSO-783

Authenticator uses java.util.logging.Logger name that does not follow standard.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • RH-SSO-7.1.0.CR2
    • RH-SSO-7.0.0.GA
    • None
    • None

      org.keycloak.adapters.tomcat.AbstractKeycloakAuthenticatorValve uses
      (1) java.util.logging.Logger.getLogger(""+AbstractKeycloakAuthenticatorValve.class)

      and

      org.keycloak.adapters.saml.AbstractSamlAuthenticatorValve uses
      (2) private final static Logger log = Logger.getLogger(""+AbstractSamlAuthenticatorValve.class);

      do not follow jdk logger name standards. This makes it impossible to configure logging level behavior.

      See java.util.logging.Logger.getLogger(String) "@param name A name for the logger. **This should be a dot-separated name and should normally be based on the package name or class name of the subsystem, such as java.net or javax.swing**"

      Proper usage for (1) would be java.util.logging.Logger.getLogger(AbstractKeycloakAuthenticatorValve.class.getName())

      and for (2)
      private final static Logger log = Logger.getLogger(AbstractSamlAuthenticatorValve.class.getName());

      And why do these Authenticator uses JDK Logger???? They are jboss specific and should conform to other jboss authenticator and use org.jboss.logging.Logger. Other keycloak classes does that.

              zschwarz Zuzana Schwarzová (Inactive)
              rhn-support-igueye Issa Gueye
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: