Maven users are being created (via bin/add-user.sh) in EAP when they should not be. Instead of only creating a user in decision/business central when the maven repository represents a producer case, it is also being done for all consumer cases as well (when it really just needs to modify the settings.xml file as a consumer).

In looking through which modules do what kind of user creation, I found the following:

rhpam-7-openshift-image/businsscentral/image.yaml

• name: os.bpmsuite.common
• name: os.bpmsuite.businesscentral

rhpam-7-openshift-image/businsscentral-monitoring/image.yaml

• name: os.bpmsuite.common
• name: os.bpmsuite.businesscentral

rhpam-7-openshift-image/controller/image.yaml

• name: os.bpmsuite.common
• name: os.bpmsuite.standalonecontroller

rhpam-7-openshift-image/kieserver/image.yaml

• name: os.bpmsuite.common
• name: os.bpmsuite.executionserver

rhpam-7-openshift-image/smartrouter/image.yaml

• name: os.bpmsuite.smartrouter

rhdm-7-openshift-image/decisioncentral/image.yaml

• name: os.bpmsuite.common
• name: os.bpmsuite.businesscentral

rhdm-7-openshift-image/kieserver/image.yaml

• name: os.bpmsuite.common
• name: os.bpmsuite.executionserver

jboss-kieserver-6-openshift-image/image.yaml

• name: os.kieserver.launch

find jboss-kie-modules -name '*.sh' | xargs grep -ln add-user\.sh
jboss-kie-modules/os.bpmsuite.common/added/launch/bpmsuite-common.sh
jboss-kie-modules/os.bpmsuite.standalonecontroller/added/launch/bpmsuite-standalonecontroller.sh
jboss-kie-modules/os.bpmsuite.executionserver/added/launch/bpmsuite-executionserver.sh
jboss-kie-modules/os.kieserver.launch/added/kieserver-setup.sh

os.bpmsuite.common

• added/launch/bpmsuite-common.sh:
  add-user.sh a --user KIE_ADMIN_USER --password KIE_ADMIN_PWD (-role KIE_ADMIN_ROLES)
  add-user.sh a --user KIE_SERVER_CONTROLLER_USER --password KIE_SERVER_CONTROLLER_PWD (-role KIE_SERVER_CONTROLLER_ROLES)
  add-user.sh a --user *MAVEN_REPO_USERNAME --password *MAVEN_REPO_PASSWORD (-role *MAVEN_REPO_ROLES)

os.bpmsuite.standalonecontroller

• added/launch/bpmsuite-standalonecontroller.sh:
  add-user.sh -a --user KIE_SERVER_CONTROLLER_USER --password KIE_SERVER_CONTROLLER_PWD

os.bpmsuite.executionserver

• added/launch/bpmsuite-executionserver.sh:
  add-user.sh -a --user KIE_SERVER_USER --password KIE_SERVER_PWD

os.kieserver.launch

• added/launch/kieserver-setup.sh:
  add-user.sh -a --user KIE_SERVER_USER --password KIE_SERVER_PWD

What we should do is:
1) Move maven eap user creation to jboss-kie-modules/os.bpmsuite.businesscentral/added/launch/bpmsuite-businesscentral.sh (out of os.bpmsuite.common).
2) Differentiate the env vars for eap user creation from MAVEN_REPO_* to KIE_MAVEN_*
3) Add the ability to override *_ROLES for everywhere we do eap user creation, with the defaults we currently hardcode.
4) Remove duplicate user creation (for example, it looks like we create the KIE_SERVER_CONTROLLER_USER in both bpmsuite-common.sh and bpmsuite-standalonecontroller.sh)