Uploaded image for project: 'Red Hat OpenShift Data Science'
  1. Red Hat OpenShift Data Science
  2. RHODS-2375

[GA blocker] RHODS controller deletes OCP APIServices

XMLWordPrintable

    • MODH Sprint 36

      Description of problem:

      The kfdef RHODS controller is deleting APIServices by index, if their condition is False: https://github.com/red-hat-data-services/opendatahub-operator/blob/336ece83898129541dd94067cd44528bce7f8f06/pkg/controller/kfdef/kfdef_controller.go#L630-L651.

      As the rhods-operator workload runs with elevated privileges (https://gitlab.cee.redhat.com/service/managed-tenants-bundles/-/blob/main/addons/rhods/main/1.3.0-6/manifests/rhods-operator.1.3.0-6.clusterserviceversion.yml#L53) this piece of code can potentially delete any OCP APIService, and break the cluster.

       

      MTSRE requirements:

      The ask would be twofold:

      1. Modify the cleanup code to only impact RHODS managed APIServices
      2. Restrict CSV permissions to least privileged (this is a best effort as we are figuring out what our allow-list or criterias will be)

              vhire Vaishnavi Hire
              sblaisdo@redhat.com Samuel Blais-Dowdy (Inactive)
              Tarun Kumar Tarun Kumar
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Created:
                Updated:
                Resolved: