** Note that this is a public ticket, please refrain from adding any sensitive data. **

Description of Problem

Red Hat Insights client creates world writable file /etc/rhsm/facts/insights-client.facts

How reproducible

Always

Steps to Reproduce

1. [Step 1] Configure insights-client on system
2. [Step 2]
3. [Step 3]

Actual Behavior

insights create world writable file /etc/rhsm/facts/insights-client.facts

Expected Behavior

Insights should create the file with correct permissions

Business Impact / Additional info

Below are more details:

1. ls -l /etc/rhsm/facts/insights-client.facts
   rw-rw-rw. 1 root root 6920 Feb 2 01:25 /etc/rhsm/facts/insights-client.facts

1. insights-client --version
   Client: 3.1.9
   Core: 3.3.4-1

1. rpm -qi insights-client|grep -E "(Name|Epoch|Version|Release|Install Date)"
   Name : insights-client
   Epoch : 0
   Version : 3.1.9
   Release : 1.el7_9
   Install Date: Thu 01 Feb 2024 03:05:30 PM CET

1. systemctl list-timers insights-client.timer
   NEXT LEFT LAST PASSED UNIT ACTIVATES
   Sat 2024-02-03 03:52:00 CET 15h left Fri 2024-02-02 01:23:46 CET 10h ago insights-client.timer insights-client.service

Discussed this on insights-client-dev slack channel
Here's a new function that creates the file
https://github.com/RedHatInsights/insights-core/blob/8e2fcbaa25b797e93e185f83f2afb5987b418187/insights/core/spec_cleaner.py#L395

As per Link Dupont, This file isn't created by the client code. It is created as part of data collection, which is managed by the core code.