Uploaded image for project: 'Red Hat Insights Engineering'
  1. Red Hat Insights Engineering
  2. RHINENG-770

Remove branch_info metadata collector

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • Insights Core
    • None
    • False
    • False
    • Hide

      None

      Show
      None

      ** Note that this is a public ticket, please refrain from adding any sensitive data. **

      Description:

      The BranchInfo parser used in Insights rules is deprecated and rules using it should use the Satellite6Version parser instead.

      Steps to Reproduce:

      1.Rules 'satellite/katello_agent_dependency_checking.py', 'satellite/remote_execution_fail_with_fips_enabled.py' and 'satellite/sat_client_rhsm_port_change.py' use the `get_satellite_version_on_content_host` function defined in 'satellite/__init__.py' to look for product information to determine the Satellite major and minor version.
      2. The `get_satellite_version_on_content_host` function uses the insights.parsers.branch_info.BranchInfo parser.
      3. The insights.parsers.branch_info.BranchInfo parser has been deprecated and emits a message saying to use the insights.parsers.client_metadata.BranchInfo parser instead.
      4. The deprecated insights.parsers.branch_info.BranchInfo parser is a YAMLParser, but the content of the branch_info file is in JSON.  Therefore it will never load.

      How reproducible: (Always / Intermittent / Random)

      Always

      Actual Results:

      Satellite version that manages the client never gets checked.

      Expected results:

      Branch_info file is loaded correctly and the rules that use it to check the client's Satellite version run correctly.

      Additional info:

      Some data in this file may need to be redacted - I would suggest only collecting the `product` data.

       

              rhn-support-zzhou Jaylin ZHOU
              rhn-support-pwayper Paul Wayper (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: