-
Task
-
Resolution: Done
-
Critical
-
1.7.0
-
None
In https://gitlab.cee.redhat.com/rhidp/rhdh-plugin-catalog/-/blob/rhdh-1-rhel-9/overlay-repo/downstream-plugins we have recently added the pagerduty plugins.
However digging into the resulting content, we see:
{"repo":"https://github.com/PagerDuty/backstage-plugin","repo-ref":"v0.15.5","repo-flat":true,"repo-backstage-version":"1.39.1"}
Same for the backend-plugin:
{"repo":"https://github.com/PagerDuty/backstage-plugin-backend","repo-ref":"v0.9.6","repo-flat":true,"repo-backstage-version":"1.39.1"}
which looks like it should be fine, but:
"version": "NPM_PACKAGE_VERSION",
So, in the event that the sources copied to the midstream don't have a real semver version, we need a way to either:
- override the value when doing a sync-midstream.sh, or
- enhance export-dynamic.sh so that...
PLUGIN_VERSION="${INPUTS_IMAGE_TAG_PREFIX}$(jq -r '.version' package.json)" PLUGIN_CONTAINER_TAG="${INPUTS_IMAGE_REPOSITORY_PREFIX}/${PLUGIN_NAME}:${PLUGIN_VERSION}"
can instead convert NPM_PACKAGE_VERSION into 0.15.5 or 0.9.6.
Note that pagerduty is listed as tech preview in https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/blob/main/modules/dynamic-plugins/rhdh-supported-plugins.csv
So this is NOT a blocker for 1.7.
- is related to
-
RHIDP-8390 improve support for applying overlays and patches (including downstreaming)
-
- Closed
-