-
Epic
-
Resolution: Done
-
Major
-
None
-
None
-
None
-
Review open PRs for rhdh-plugin-export-overlays repo
-
M
-
False
-
-
False
-
In Progress
-
QE Needed, Docs Needed, TE Needed, Customer Facing, PX Needed
-
0% To Do, 0% In Progress, 100% Done
-
Release Note Not Required
-
Release Note Not Required
-
-
EPIC Goal
Joint effort to assist in reviewing the many PRs that have been opened up in the rhdh-plugin-export-overlays repo. https://github.com/redhat-developer/rhdh-plugin-export-overlays
Background/Feature Origin
This is the current repo where we will be exposing the artifacts for RHDH consumption.
Why is this important?
There are many PRs that need to be reviewed in a timely manner
Steps
- Choose a plugin to review based on the list of tasks below
- Navigate to the PR linked within the task
- Add the comment `/publish` to the PR to ensure that the plugin has been recently published
- After the comment `Publish workflow has completed with success` has been added to the PR, navigate to the publish action
- Can be done by selecting the dropdown arrow next to `All checks have passed`
- Select the `export.Export` job
- Select the `Export dynamic plugin packages` step
- Here you will find a sample config for the plugin that you are testing
- Should be something like `Here is an example dynamic-plugins.yaml for these plugins:`
- Note: there could be multiple lines for different plugins
- Add the example config to either your RHDH local or deployed RHDH 1.5 instance
- Note: some plugins may require additional configuration options, be sure to check with the README of the plugin to be sure
- Some plugins are difficult and require account creation to set up, if this is the case, consider setting some default values for the config and just check that the plugin loads using the pod logs and extensions page
- Attempt to access the plugin and capture a few screenshots:
- Should include screenshots: a log in which the plugin was loaded, the plugin in the extensions page
- May include screenshots: attempts to use the plugin
- If the plugin successfully loaded and worked, include the screenshots and the config that you used to test as a comment to the PR
- Also, approve the PR and add the labels 'lgtm' and 'tested'
- If the plugin failed to load or had some issues, attempt to diagnose and fix
- Some example fixes include:
- Incorrect scalprum name in the package.json for Bulk Import plugins: https://github.com/redhat-developer/rhdh-plugin-export-overlays/pull/1042
- Missing icons for the Tech Radar plugin: https://github.com/redhat-developer/rhdh-plugin-export-overlays/pull/1040
- Embedded module needed: https://github.com/redhat-developer/rhdh-plugin-export-overlays/pull/1043
- Some example fixes include:
Acceptance Criteria
Review and approve PRs
Review Process
- is cloned by
-
RHIDP-8217 Review open PRs for rhdh-plugin-export-overlays repo Release-1.6
-
- Closed
-
- is related to
-
RHIDP-7315 [UI team] Test initial rhdh-plugin-export-overlays container images / PRs
-
- In Progress
-