-
Task
-
Resolution: Unresolved
-
Critical
-
1.10.0
-
None
-
RHDH Security 3287
Task
All the CI jobs use unnecessary or badly configured Github integrations.
Adjusting the configuration and removing the unnecessary ones will help reducing Github API calls and avoiding rate limits.
2. Catalog Entity Refresh Interval (approx impact on rate limit 30-40%)
There is no custom processingInterval configured for catalog entity refresh. According to the documentation, the default is 30 minutes and our tests runs for longer than this.
We may want to increase this to 24 hours: * https://github.com/redhat-developer/rhdh/blob/d434aa5/.ibm/pipelines/resources/config_map/app-config-rhdh.yaml#L144-L169
3. Unnecessary GitHub Providers in showcase-sanity-plugins Deployment (approx impact on rate limit 25-30%)
The showcase-sanity-plugins deployment runs GitHub providers unnecessarily.
It inherits values_showcase.yaml, which includes GitHub and GitHubOrg providers. However, it appears that this deployment does not require GitHub org/entity discovery, yet it still consumes the rate limit.
We can override or disable this in the overlay config: * https://github.com/redhat-developer/rhdh/blob/d434aa5/.ibm/pipelines/value_files/diff-values_showcase-sanity-plugins.yaml
4. There is duplicate GitHub Catalog Provider Configurations (Approx impact 3-5%)
The GitHub entity provider is configured in two places, and both configurations are loaded, effectively doubling the discovery calls:
• In app-config-rhdh.yaml https://github.com/redhat-developer/rhdh/blob/d434aa5/.ibm/pipelines/resources/config_map/app-config-rhdh.yaml#L194-L200
• In values_showcase.yaml as dynamic plugin config: https://github.com/redhat-developer/rhdh/blob/d434aa5/.ibm/pipelines/value_files/values_showcase.yaml#L126-L142
5. githubOrg Provider Configured Twice (Approx impact 5-10%)
The githubOrg provider is configured twice with different settings. Although these configurations are merged at runtime, they should exist in only one place. * https://github.com/redhat-developer/rhdh/blob/d434aa5/.ibm/pipelines/resources/config_map/app-config-rhdh.yaml#L201-L204
We should probably keep the second configuration and extend the frequency to 24 hours.
Background
Dependencies and Blockers
QE impacted work
Documentation impacted work
Acceptance Criteria