-
Task
-
Resolution: Done-Errata
-
Major
-
None
This will mostly be `logger.warning()` calls but `logger.info` should also be looked at to see if there is information in there that should be passed back.
Some places that definitely should be examined (These were found by looking at where we removed ask_to_continue in this PR https://github.com/oamg/convert2rhel/pull/790/files# )
- handle_packages
- package_updates:
- Actions which call remove_pkgs_unless_from_redhat https://github.com/oamg/convert2rhel/pull/790/files#diff-361f5dc14483ec43e37529967acee396da5714dbf6562472ccece5db4bba5e0dR579
- Actions which call remove_original_subscription_manager https://github.com/oamg/convert2rhel/pull/790/files#diff-51e9ff11d39778d3b26778b293fc350430a82e2feed0dab2938da7c0069ffdc6R566
- Actions which call check_needed_repos_availability https://github.com/oamg/convert2rhel/pull/790/files#diff-51e9ff11d39778d3b26778b293fc350430a82e2feed0dab2938da7c0069ffdc6R929
Some thoughts on the design of the framework to handle these:
- We need to have separate returns for final results (SUCCESS, FAILURE, and SKIP) because there must be one and only one of those after run() finishes.
- final result messages should be a list so that adding multiple messages to SUCCESS can be nicely formatted.
- WARNING, and other things that can occur multiple times should be stored in a new list attribute on the Action class.
- When evaluating logger.warning and logger.info, decide whether to set it as a SUCCESS messages or WARNING message. success messages will not be shown in convresion, only in analyze. warning messages will be shown in both.
- add_result() should be renamed since we want results to be final results only. Maybe add_message()?
Design notes: https://gist.github.com/pr-watson/6fee04e75bdad40287cb1e51d70ba702
- links to
-
RHEA-2023:120152 convert2rhel bug fix and enhancement update
-
RHEA-2023:120153 convert2rhel bug fix and enhancement update