Uploaded image for project: 'RHEL Conversions'
  1. RHEL Conversions
  2. RHELC-852

Rework the internet access availability check

XMLWordPrintable

    • False
    • False
    • Hide

      Aleksandra to update the acceptance criteria

      Show
      Aleksandra to update the acceptance criteria
    • 3
    • Testable

      After getting an issue on Convert2RHEL GitHub mentioning that the [https://github.com/oamg/convert2rhel/blob/main/convert2rhel/systeminfo.py#L363|_check_internet_access()]
      raised an error during the conversion, the user who reported it suggested that we add some sort of manual control to this variable, either by using a command line flag or environment variable, so the user, which knows if the system has internet or not, can actually tell Convert2RHEL the correct state of his connection.

      Also, bparry@redhat.com noted that some customers in the public sector space tightly control their network connectivity with firewalls etc., and customers may prefer to control the tool reaching out externally with a variable.

      Issue on Convert2RHEL GitHub

      Notes

      • As mentioned in the issues by the user how opened it, it would be very difficult for us to check against all possible edge cases for checking if there is an internet connection or not, although, I think it would be valuable to add a few more catches to the exception handler to prevent, at least, some of those cases breaking the rest of the conversion.

      Acceptance Criteria

      • Add a flag (or an environment variable) for the user to determinate if the system has internet connection or not.
      • Update the code to detect this flag (or env var), and change the state of the internal property accordingly with the value get from this new mechanism.
      • Output a log message to inform that we are using the value taken from the flag (or env var) rather than trying to determinate on our own the state of the connection.
      • Detect the exception that raises error: [Errno 104] Connection reset by peer and catch it in the code
      • Close the GitHub issue once the resultant PR is merged in upstream.

              Unassigned Unassigned
              rolivier@redhat.com Rodolfo Olivieri
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: