Uploaded image for project: 'RHEL Conversions'
  1. RHEL Conversions
  2. RHELC-670

Clean-up for the check for a new version available

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Minor Minor
    • 1.1
    • None
    • None
    • False
    • False
    • Hide

      None

      Show
      None
    • 2
    • 2022-Q3, 2022-Q4

      • PR# 415 got merged with a few comments left over for some clean-up on the PR; none of the comments were volatile enough to stop the PR from being merged. 

      check to see that this PR doesn't have anymore adjustments that could be made at the moment.

       

      Acceptance criteria

      1. Change the message that is displayed, to explain how the user should use the environment variable https://github.com/oamg/convert2rhel/pull/415#discussion_r919429213
      2. either explain what is going on when the variable var_comp < 0 or move it to its own function   https://github.com/oamg/convert2rhel/pull/415#discussion_r919431919
      3. reword the messages to so they are more clear messages https://github.com/oamg/convert2rhel/pull/415#discussion_r919447754  [ https://github.com/oamg/convert2rhel/pull/415#discussion_r919447500 
      4. https://github.com/oamg/convert2rhel/pull/415#discussion_r919448240
      5. return_code is not important to the user and so it should be taken out of the messages that use it https://github.com/oamg/convert2rhel/pull/415#discussion_r919451357
      6. change the name of "convert2rhel_versionlatest_version" in the code to make it easier to understand what the difference between the two variables are https://github.com/oamg/convert2rhel/pull/415#discussion_r919463762
      7. add a comment to the ssl_cert_path noting what cdn server it's going to https://github.com/oamg/convert2rhel/pull/415#discussion_r919449915
      8. add a task log message to let the user know that the check is starting https://github.com/oamg/convert2rhel/pull/415/files#r919448240
      9. skip the check to see if the internet connection is not available to prevent bloating log messages https://github.com/oamg/convert2rhel/pull/415#discussion_r926837881
      10. edit the CDN link so that it doesn't hard code the architecture x86_64 as there might be more added in the future  https://github.com/oamg/convert2rhel/pull/415#discussion_r919442989
      11. move the gpg_path and the ssl_cert_path and the repo_contnet to the module level with the other constants https://github.com/oamg/convert2rhel/pull/415#discussion_r919440187

              aanglin@redhat.com Andrew Anglin
              aanglin@redhat.com Andrew Anglin
              Toshio Kuratomi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: