When we first enabled pylint back in 2021 we made the decision of only listening to errors and fatal messages, and exclude all other message types. This creates a few issues as we have warnings we do want to listen to, but some others that we don't want to listen to at all due to compatibility issues or incorrect warnings. Some warnings we do care about is cyclic imports, lazy logging, and no newline at end of file.

We want to go through the warnings throughout the codebase and address every single message by either fixing or permanently disable each one. Some will need to be permanently disabled due to python 2 and 3 compatibility issues

Messages and their occurrence:

• Occurrences with code+tests
  • https://gist.github.com/abadger/b0f4324f76ae2e8c6a5fd1bd2f8b6725
• Occurrences with code
  • https://gist.github.com/abadger/bdd3f6313f62c7af70d472ae603cc98d

Acceptance Criteria

• All messages of pylint have been addressed that's reported in main branch
• Pylint return code parser has been change to throw error on warnings as well (possibly even even higher levels)
• Linting works for both code and tests

Stretch goal

• Get GitHub PR annotation on each line with offending pylint message (similar to Codecov)