Uploaded image for project: 'RHEL Conversions'
  1. RHEL Conversions
  2. RHELC-1516

Removing the file backup when restoring outside of rollback

XMLWordPrintable

    • False
    • False
    • Hide

      None

      Show
      None
    • 3
    • Testable

      We have RestorableFile in files.py. We are using the RestorableFile for backing up the /etc/os-release file, which we restore during registration process of the system. The file is then removed after the registration.

      The problem is, that we are now removing the backup when doing the restore even outside the rollback. This doesn't correspond to the comments in the code.

      It wasn't a problem before, when we were checking if the backed up file exists. But I've changed that to have this backup error captured, and the error can be provided to the user and not just skip this without capturing it in the final BackupController message about errors during rollback.

      But now rollback fails with message the os-release file couldn't been restored due missing the file in backup folder (previously it was just skipped as missing the backup). It's not a big deal as the file is generated again during rollback of the centos-release pkg.

      Possible solutions:

              ahosek@redhat.com Adam Hosek
              ahosek@redhat.com Adam Hosek
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: