Uploaded image for project: 'RHEL Conversions'
  1. RHEL Conversions
  2. RHELC-1320

Replace critical_with_exit with raising an exception

XMLWordPrintable

    • 2
    • Testable

      This is a code cleanup followup to RHELC-1319. Again, from clean code perspective, a logging function should not cause a program to exit which is what happens now when we call logger.critical_with_exit().

      Acceptance criteria:

      1. Port individual uses of logger.critical_with_exit() to logger.critical(). For each usage this requires:
        1. Switching the call
        2. Defining or deciding on an appropriate exception to raise instead
        3. Auditing all the code's callers to catch and deal with the new exception if appropriate.
      2. When all uses of logger.critical() have been ported, remove critical_with_exit() and supporting code in logger.py

              Unassigned Unassigned
              mbocek@redhat.com Michal Bocek
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: