The script that invokes convert2rhel pre-analysis for insights has some things that are legitimate transformations of the data which should be done at the transformation layer but it also contains some other things that are just workarounds for doing things differently for no reason.

Criteria for deciding which of these is correct: https://github.com/oamg/convert2rhel/wiki/Relationship-of-convert2rhel-json-output-and-the-data-that-Insights-ingests

When we make these changes, several things need to be examined and probably changed:

• the code that generates the json output (in actions/report.py)
• In most cases, the internal representation of the data should be changed (most likely in actions/{}init{}.py)
• The schema that validates the data we produce needs to be updated and the schema version needs to be increased.

As of convert2rhel-1.4 and Conversions-in-Insights MVP, we have the following changes in the script that should move into convert2rhel itself:

• The remediation (singular) key in the convert2rhel output needs to be changed to remediations (plural).