Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-89417

xdg-destkop-portal-gtk: FTBFS with xdg-desktop-portal >= 1.19.1

Linking RHIVOS CVEs to...Migration: Automation ...SWIFT: Generate New Ti...SWIFT: POC ConversionSync from "Extern...XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • rhel-10.1
    • rhel-10.0
    • xdg-desktop-portal-gtk
    • None
    • xdg-desktop-portal-gtk-1.15.3-1.el10
    • No
    • Moderate
    • 1
    • rhel-display-window-mgmt
    • ssg_display
    • 3
    • False
    • False
    • Hide

      None

      Show
      None
    • None
    • Display WM #3/2025
    • Unspecified
    • Unspecified
    • Unspecified
    • None

      As per the subject, xdg-desktop-portal-gtk currently fails to build
      from source:

      $ git log --oneline | head -1
      0e5c362 Bump release for October 2024 mass rebuild:
      
      $ centpkg --release c10s mockbuild
      ...
      FAILED: src/xdg-desktop-portal-gtk.p/notification.c.o 
      gcc -Isrc/xdg-desktop-portal-gtk.p -Isrc -I../src -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/webp -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/fribidi -I/usr/include/libxml2 -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gtk-3.0/unix-print -I/usr/include/gsettings-desktop-schemas -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64-v3 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -pthread -DWITH_GZFILEOP '-DLOCALEDIR="/usr/share/locale"' -DBUILD_SETTINGS -DBUILD_APPCHOOSER -MD -MQ src/xdg-desktop-portal-gtk.p/notification.c.o -MF src/xdg-desktop-portal-gtk.p/notification.c.o.d -o src/xdg-desktop-portal-gtk.p/notification.c.o -c ../src/notification.c
      ../src/notification.c: In function 'notification_added':
      ../src/notification.c:33:35: warning: unused parameter 'source' [-Wunused-parameter]
         33 | notification_added (GObject      *source,
            |                     ~~~~~~~~~~~~~~^~~~~~
      ../src/notification.c:35:35: warning: unused parameter 'data' [-Wunused-parameter]
         35 |                     gpointer      data)
            |                     ~~~~~~~~~~~~~~^~~~
      ../src/notification.c: In function 'handle_add_notification_gtk':
      ../src/notification.c:62:3: error: too few arguments to function 'xdp_impl_notification_complete_add_notification'
         62 |   xdp_impl_notification_complete_add_notification (object, invocation);
            |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      In file included from ../src/notification.c:18:
      src/xdg-desktop-portal-dbus.h:1597:6: note: declared here
       1597 | void xdp_impl_notification_complete_add_notification (
            |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../src/notification.c: In function 'activate_action':
      ../src/notification.c:108:27: warning: unused parameter 'data' [-Wunused-parameter]
        108 |                  gpointer data)
            |                  ~~~~~~~~~^~~~
      ../src/notification.c: In function 'handle_add_notification_fdo':
      ../src/notification.c:176:3: error: too few arguments to function 'xdp_impl_notification_complete_add_notification'
        176 |   xdp_impl_notification_complete_add_notification (object, invocation);
            |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      src/xdg-desktop-portal-dbus.h:1597:6: note: declared here
       1597 | void xdp_impl_notification_complete_add_notification (
            |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      

      The issue has already been reported and resolved upstream.

      I have prepared a fix that involves backporting the following
      upstream commit:

      https://github.com/flatpak/xdg-desktop-portal-gtk/commit/fe253f0a3296d44e23c6075b1d78638da78abe71

      There were some conflicts to deal with so it's not a clean
      cherry-pick, but the fix is still very minimal and targeted.

      The alternative solution would be to rebase xdg-desktop-portal-gtk to
      upstream version 1.15.3, which contains this fix among several
      others. That's already happened in Fedora. Which way to go is left to
      the maintainers' discretion

              jadahl@redhat.com Jonas Ådahl
              rhn-engineering-abologna Andrea Bolognani
              Jonas Ådahl Jonas Ådahl
              Michal Odehnal Michal Odehnal
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated: