Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-85787

[RHEL-9.7] Provide validation of OVN Bridge Mapping before applying

Linking RHIVOS CVEs to...Migration: Automation ...SWIFT: POC ConversionSync from "Extern...XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • rhel-9.7
    • None
    • nmstate
    • nmstate-2.2.48-1.el9
    • None
    • rhel-net-mgmt
    • ssg_networking
    • 1
    • False
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • Hide

      Definition of Done:

      Please mark each item below with ( / ) if completed or ( x ) if incomplete:

      ( ) The acceptance criteria defined below are met.

      Given a system administrator applies an Nmstate configuration that includes an OVN bridge mapping,

      When the configuration specifies an OVS bridge that does not exist,

      Then, Nmstate must reject the configuration and return a clear error message without applying any changes.

      Definition of Done:

      • The implementation meets the acceptance criteria
      • Integration tests are written to verify that configurations with non-existent bridge mappings are rejected
      • The code is part of a downstream build attached to an errata

      ( ) Code changes are included in a downstream build attached to an errata.

      ( ) All required testing (manual and/or automated) passes successfully.

      ( ) Related documentation updates (if applicable) have been completed.

      Show
      Definition of Done: Please mark each item below with ( / ) if completed or ( x ) if incomplete: ( ) The acceptance criteria defined below are met. Given a system administrator applies an Nmstate configuration that includes an OVN bridge mapping, When the configuration specifies an OVS bridge that does not exist, Then, Nmstate must reject the configuration and return a clear error message without applying any changes. Definition of Done: The implementation meets the acceptance criteria Integration tests are written to verify that configurations with non-existent bridge mappings are rejected The code is part of a downstream build attached to an errata ( ) Code changes are included in a downstream build attached to an errata. ( ) All required testing (manual and/or automated) passes successfully. ( ) Related documentation updates (if applicable) have been completed.
    • Requested
    • Automated
    • None

      Goal

      • As a user, I would like to prevent myself from making simple, but breaking mistakes, by having OVN validate that my bridge mapping is valid before applying it.

      Acceptance Criteria

      If try to apply an nmsate config that tries to map a localnet to a bridge that doesn't exist, nmstate should fail the config and not apply it.

       

      For example this should apply successfully, because the localnet, vlan-99 is mapped to a bridge that exists, ovs-br0 (OCP NNCP example):

      spec:   
  nodeSelector:     
    node-role.kubernetes.io/worker: ''  
  desiredState: 
    interfaces: 
    - name: ovs-br0
      type: ovs-bridge
      state: up
      bridge: 
        options: 
          stp: true
        port: 
        - name: eno4  
    ovn: 
      bridge-mappings: 
      - localnet: vlan-99
        bridge: ovs-br0
        state: present

       

       

      This example should fail, because ovs-br12345 does not exist (OCP NNCP example):

      spec: 
  nodeSelector: 
    node-role.kubernetes.io/worker: ''  
  desiredState: 
     interfaces: 
     - name: ovs-br0
       type: ovs-bridge
       state: up
       bridge: 
         options: 
           stp: true
         port: 
         - name: eno4  
    ovn: 
      bridge-mappings: 
      - localnet: vlan-99
        bridge: ovs-br12345
        state: present
 

       

       

       

              rh-ee-sfaye Stanislas Faye
              bmarlow@redhat.com Brandon Marlow
              Network Management Team Network Management Team
              Mingyu Shi Mingyu Shi
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Created:
                Updated:
                Resolved: