Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-83973

passt's socket for TCP connection repair helper can't be easily used with libvirt-based migration

Linking RHIVOS CVEs to...Migration: Automation ...SWIFT: POC ConversionSync from "Extern...XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • rhel-10.1
    • rhel-9.6, rhel-10.0
    • passt
    • No
    • Important
    • ZStream, 0day
    • rhel-virt-networking-passt-pasta
    • ssg_virtualization
    • None
    • False
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • Approved Blocker
    • None
    • None
    • Unspecified
    • Unspecified
    • Unspecified
    • All
    • None

      This was first mentioned by yalzhang@redhat.com in RHEL-69455. We initially thought it wouldn't affect layered products (KubeVirt / OpenShift Virtualisation), but it actually does, because also in KubeVirt there's no accessible hook on the migration target between:

      1. libvirt preparing the domain (and starting helpers, such as virtiofsd and passt)
      2. libvirt starting the guest (QEMU) and the migration

      The helper passt uses to switch connections to repair mode for migration (passt-repair) would need to be executed once passt is ready (after 1.) but before passt needs to actually restore connections (before 2.).

      That's because passt-repair connects to passt, and passt expects passt-repair to be already connected while restoring connections on the target.

      There's no way, however, not even in KubeVirt, to block 2. and run the helper as intermediate step before that.

      As a minimal fix for this issue, we implemented, upstream:

      With these changes, passt-repair can be started on the target before libvirt starts migrating, e.g. passt-repair /run/user/1000/libvirt/qemu/run/passt/, or, in KubeVirt case, /run/user/107/libvirt/qemu/run/passt/.

              sbrivio@redhat.com Stefano Brivio
              sbrivio@redhat.com Stefano Brivio
              Stefano Brivio Stefano Brivio
              Han Han Han Han
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Created:
                Updated:
                Resolved: