Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-78511

Failed to change ethtool.coalesce.tx-usecs

Linking RHIVOS CVEs to...Migration: Automation ...SWIFT: POC ConversionSync from "Extern...XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • rhel-9.6
    • nmstate
    • No
    • None
    • rhel-net-mgmt
    • ssg_networking
    • None
    • False
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • Hide

      Definition of Done:

      Please mark each item below with ( / ) if completed or ( x ) if incomplete:

      ( ) The acceptance criteria defined below are met.

      Given a YAML with valid ethtool.coalesce.tx-usecs and other coalesce settings,

      When nmstatectl apply is run,

      Then all settings are applied successfully, and if tx-usecs fails, rollback is triggered and no settings are changed

      ( ) Integration test case is available upstream.

      ( ) Code is reviewed and merged upstream.

      ( ) Preliminary testing is done.

      ( ) Upstream documentation is written in the upstream MR.

      ( ) Release notes text is written in the RHEL issue.

      ( ) A demo is recorded

      Show
      Definition of Done: Please mark each item below with ( / ) if completed or ( x ) if incomplete: ( ) The acceptance criteria defined below are met. Given a YAML with valid ethtool.coalesce.tx-usecs and other coalesce settings, When nmstatectl apply is run, Then all settings are applied successfully, and if tx-usecs fails, rollback is triggered and no settings are changed ( ) Integration test case is available upstream. ( ) Code is reviewed and merged upstream. ( ) Preliminary testing is done. ( ) Upstream documentation is written in the upstream MR. ( ) Release notes text is written in the RHEL issue. ( ) A demo is recorded
    • None
    • None
    • None

      What were you trying to do that didn't work?

      Failed to change ethtool.coalesce.tx-usecs. There are 2 issues:
      1. Verification failed on tx-usecs
      2. Failed but no rollback, the other changes were applied. It was not an atomic transacton

       

      It seems no tx-usecs manipulation in NM trace log during nmstatectl apply

      Directly using `nmcli` works well

      What is the impact of this issue to you?

      Please provide the package NVR for which the bug is seen:

      nmstate-2.2.40-1.el9.x86_64
      NetworkManager-1.51.6-1.el9.x86_64

      How reproducible is this bug?:

      always

      Steps to reproduce

      The init state:
            coalesce:
              adaptive-rx: true
              adaptive-tx: true
              rx-usecs: 50
              rx-usecs-high: 0
              tx-frames-irq: 256
              tx-usecs: 50
              tx-usecs-high: 0

      echo "interfaces:
  - name: ens2f0
    type: ethernet
    state: up
    ethtool:
      coalesce:
        adaptive-rx: false
        adaptive-tx: false
        rx-usecs: 60
        rx-usecs-high: 8
        tx-frames-irq: 512
        tx-usecs: 60
        tx-usecs-high: 8" | nmstatectl apply

      Expected results

      All changed as the desired

      Actual results

      Failed, no rollback and all changed except tx-usecs:

       

      [2025-02-10T02:58:24Z INFO  nmstatectl] Nmstate version: 2.2.40
[2025-02-10T02:58:24Z INFO  nmstate::query_apply::net_state] Created checkpoint /org/freedesktop/NetworkManager/Checkpoint/1
[2025-02-10T02:58:24Z INFO  nmstate::nm::query_apply::profile] Creating connection UUID Some("8fe33f70-77d9-4edf-8f71-4fbe3bc9f5c4"), ID Some("ens2f0"), type Some(Ethernet) name Some("ens2f0")
[2025-02-10T02:58:24Z INFO  nmstate::nm::query_apply::profile] Activating connection 8fe33f70-77d9-4edf-8f71-4fbe3bc9f5c4: ens2f0/802-3-ethernet
[2025-02-10T02:58:24Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: ens2f0.interface.ethtool.coalesce.tx-usecs desire '60', current '50'
[2025-02-10T02:58:25Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: ens2f0.interface.ethtool.coalesce.tx-usecs desire '60', current '50'
[2025-02-10T02:58:26Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: ens2f0.interface.ethtool.coalesce.tx-usecs desire '60', current '50'
[2025-02-10T02:58:27Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: ens2f0.interface.ethtool.coalesce.tx-usecs desire '60', current '50'
[2025-02-10T02:58:28Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: ens2f0.interface.ethtool.coalesce.tx-usecs desire '60', current '50'
[2025-02-10T02:58:31Z INFO  nmstate::nm::query_apply::profile] Modifying connection UUID Some("8fe33f70-77d9-4edf-8f71-4fbe3bc9f5c4"), ID Some("ens2f0"), type Some(Ethernet) name Some("ens2f0")
[2025-02-10T02:58:31Z INFO  nmstate::nm::query_apply::profile] Reapplying connection 8fe33f70-77d9-4edf-8f71-4fbe3bc9f5c4: ens2f0/802-3-ethernet
[2025-02-10T02:58:31Z INFO  nmstate::nm::query_apply::profile] Reapplying connection 8fe33f70-77d9-4edf-8f71-4fbe3bc9f5c4: ens2f0/802-3-ethernet
[2025-02-10T02:58:31Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: ens2f0.interface.ethtool.coalesce.tx-usecs desire '60', current '50'
[2025-02-10T02:58:32Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: ens2f0.interface.ethtool.coalesce.tx-usecs desire '60', current '50'
[2025-02-10T02:58:33Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: ens2f0.interface.ethtool.coalesce.tx-usecs desire '60', current '50'
[2025-02-10T02:58:34Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: ens2f0.interface.ethtool.coalesce.tx-usecs desire '60', current '50'
[2025-02-10T02:58:35Z INFO  nmstate::query_apply::net_state] Rollbacked to checkpoint /org/freedesktop/NetworkManager/Checkpoint/1
NmstateError: VerificationError: Verification failure: ens2f0.interface.ethtool.coalesce.tx-usecs desire '60', current '50'
[10:58:35@dell-per760-01 ethtool]1# nmstatectl show ens2f0 | yq .interfaces.[0].ethtool.coalesce
[2025-02-10T02:58:45Z INFO  nmstatectl] Nmstate version: 2.2.40
adaptive-rx: false
adaptive-tx: false
rx-usecs: 60
rx-usecs-high: 8
tx-frames-irq: 256
tx-usecs: 50
tx-usecs-high: 8
[10:58:46@dell-per760-01 ethtool]0# ethtool -c ens2f0
Coalesce parameters for ens2f0:
Adaptive RX: off  TX: off
stats-block-usecs:      n/a
sample-interval:        n/a
pkt-rate-low:           n/a
pkt-rate-high:          n/a
rx-usecs:       60
rx-frames:      n/a
rx-usecs-irq:   n/a
rx-frames-irq:  n/a
tx-usecs:       50
tx-frames:      n/a
tx-usecs-irq:   n/a
tx-frames-irq:  256
rx-usecs-low:   n/a
rx-frame-low:   n/a
tx-usecs-low:   n/a
tx-frame-low:   n/a
rx-usecs-high:  8
rx-frame-high:  n/a
tx-usecs-high:  8
tx-frame-high:  n/a
CQE mode RX: n/a  TX: n/a
tx-aggr-max-bytes:      n/a
tx-aggr-max-frames:     n/a
tx-aggr-time-usecs:     n/a

       

        1. nmtrace.log
          122 kB
          Mingyu Shi

              nm-team Network Management Team
              rh-ee-mshi1 Mingyu Shi
              Network Management Team Network Management Team
              Mingyu Shi Mingyu Shi
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated: