Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-76268

nmstate shouldn't verify the speed when auto negotiate is enabled

Linking RHIVOS CVEs to...Migration: Automation ...SWIFT: POC ConversionSync from "Extern...XMLWordPrintable

    • nmstate-2.2.50-1.el10
    • No
    • Assignee, Qa Contact, Doc Contact, AssignedTeam, Watchers, Developer
    • Moderate
    • 1
    • rhel-net-mgmt
    • ssg_networking
    • 1
    • False
    • False
    • Hide

      None

      Show
      None
    • None
    • NMT SST - Refine next
    • Hide

      Definition of Done:

      Please mark each item below with ( / ) if completed or ( x ) if incomplete:

      ( ) The acceptance criteria defined below are met.

      Given a network interface with a configured speed of 1000 Mbps and no pending changes,

      When the system administrator runs nmstatectl show <interface> | nmstatectl apply on that interface,

      Then nmstate completes without triggering a link DOWN/UP event or rollback due to a verification error on ethernet.speed.

      ( ) Code changes are included in a downstream build attached to an errata.

      ( ) All required testing (manual and/or automated) passes successfully.

      ( ) Related documentation updates (if applicable) have been completed.

      Show
      Definition of Done: Please mark each item below with ( / ) if completed or ( x ) if incomplete: ( ) The acceptance criteria defined below are met. Given a network interface with a configured speed of 1000 Mbps and no pending changes, When the system administrator runs nmstatectl show <interface> | nmstatectl apply on that interface, Then nmstate completes without triggering a link DOWN/UP event or rollback due to a verification error on ethernet.speed. ( ) Code changes are included in a downstream build attached to an errata. ( ) All required testing (manual and/or automated) passes successfully. ( ) Related documentation updates (if applicable) have been completed.
    • Pass
    • Automated
    • None

      What were you trying to do that didn't work?

      The link flapping issue of applying mp-tcp (https://issues.redhat.com/browse/RHEL-53211 ) has been fixed in https://github.com/nmstate/nmstate/pull/2833 , but running the reproducer can still observe the link down/up, which is caused by rollback on verification failure of ethernet.speed

      Tested on beaker machines

      dell-per740-80.rhts.eng.pek2.redhat.com

      dell-per740-86.rhts.eng.pek2.redhat.com

      What is the impact of this issue to you?

      Link down/up, this will cause the network traffic loss

      Please provide the package NVR for which the bug is seen:

      nmstate-2.2.40-0.20250120.2444git2133c4ba.el9.x86_64
      NetworkManager-1.51.5-1.el9.x86_64

      How reproducible is this bug?:

      100%

      Steps to reproduce

      1.  Reserve a (beaker) clean machine with the gateway interface set on a physical NIC
      2.  ip monitor link &> monitor.log 
      3.  nmstatectl show $gateway_nic | nmstatectl apply
      4.  cat monitor.log

      Expected results

      No link DOWN as there is nothing changed in the desired state

      Actual results

      link DOWN and then UP

       

      nmstate log:

      [17:37:50@dell-per740-80 ~]0# nmstatectl show eno1 | nmstatectl apply
[2025-01-25T09:38:18Z INFO  nmstatectl] Nmstate version: 2.2.40
[2025-01-25T09:38:18Z INFO  nmstatectl] Nmstate version: 2.2.40
[2025-01-25T09:38:18Z INFO  nmstate::ip] Static addresses 10.73.131.113/23 valid_life_time 86291sec preferred_lft 86291sec defined when dynamic IP is enabled
[2025-01-25T09:38:18Z INFO  nmstate::ip] Ignoring Auto IP address 10.73.131.113/23 valid_life_time 86291sec preferred_lft 86291sec
[2025-01-25T09:38:18Z INFO  nmstate::ip] Ignoring Auto IP address 2620:52:0:4982:3648:edff:fefa:2758/64 valid_life_time 2591965sec preferred_lft 604765sec
[2025-01-25T09:38:18Z INFO  nmstate::ip] Static addresses fe80::3648:edff:fefa:2758/64 defined when dynamic IP is enabled
[2025-01-25T09:38:18Z WARN  nmstate::ip] Ignoring IPv6 link local address fe80::3648:edff:fefa:2758/64
[2025-01-25T09:38:18Z INFO  nmstate::query_apply::net_state] Created checkpoint /org/freedesktop/NetworkManager/Checkpoint/7
[2025-01-25T09:38:18Z INFO  nmstate::nm::query_apply::profile] Modifying connection UUID Some("fb455ea2-eb4d-4ea9-8978-2a89e5169855"), ID Some("eno1"), type Some(Ethernet) name Some("eno1")
[2025-01-25T09:38:18Z INFO  nmstate::nm::query_apply::profile] Reapplying connection fb455ea2-eb4d-4ea9-8978-2a89e5169855: eno1/802-3-ethernet
[2025-01-25T09:38:18Z INFO  nmstate::nm::query_apply::profile] Reapplying connection fb455ea2-eb4d-4ea9-8978-2a89e5169855: eno1/802-3-ethernet
[2025-01-25T09:38:18Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: eno1.interface.ethernet.speed desire '1000', current 'null'
[2025-01-25T09:38:19Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: eno1.interface.ethernet.speed desire '1000', current 'null'
[2025-01-25T09:38:20Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: eno1.interface.ethernet.speed desire '1000', current 'null'
[2025-01-25T09:38:22Z INFO  nmstate::query_apply::net_state] Retrying on: VerificationError: Verification failure: eno1.interface.ethernet.speed desire '1000', current 'null'
[2025-01-25T09:38:23Z INFO  nmstate::query_apply::net_state] Destroyed checkpoint /org/freedesktop/NetworkManager/Checkpoint/7
[2025-01-25T09:38:23Z INFO  nmstate::ip] Static addresses 10.73.131.113/23 valid_life_time 86291sec preferred_lft 86291sec defined when dynamic IP is enabled
[2025-01-25T09:38:23Z INFO  nmstate::ip] Ignoring Auto IP address 10.73.131.113/23 valid_life_time 86291sec preferred_lft 86291sec
[2025-01-25T09:38:23Z INFO  nmstate::ip] Ignoring Auto IP address 2620:52:0:4982:3648:edff:fefa:2758/64 valid_life_time 2591965sec preferred_lft 604765sec
[2025-01-25T09:38:23Z INFO  nmstate::ip] Static addresses fe80::3648:edff:fefa:2758/64 defined when dynamic IP is enabled
[2025-01-25T09:38:23Z WARN  nmstate::ip] Ignoring IPv6 link local address fe80::3648:edff:fefa:2758/64
route-rules: {}
routes: {}
interfaces:
- name: eno1
  type: ethernet
  state: up
  mptcp:
    address-flags: []
ovn: {}

       

              rhn-engineering-vbenes Vladimir Benes
              rh-ee-mshi1 Mingyu Shi
              Network Management Team Network Management Team
              Vladimir Benes Vladimir Benes
              Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

                Created:
                Updated: