Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-76176

[RFE] Include device identity in `pcs stonith sbd watchdog list` output [rhel-10]

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Major Major
    • rhel-10.1
    • None
    • pcs
    • Moderate
    • FutureFeature
    • Customer Reported
    • rhel-sst-high-availability
    • 13
    • 23
    • 0
    • False
    • Hide

      None

      Show
      None
    • Yes
    • None
    • Enhancement
    • Hide
      Feature, enhancement:
      When listing available watchdogs, print identity and driver of each watchdog.

      Reason:
      Previously, only watchdog path was printed, which was not enough for the users to figure out the right watchdog in case tehre were more than one.

      Result:
      Watchdog listing now includes watchdog path, identity and driver, so that it is possible to distinguish the watchdogs.
      Show
      Feature, enhancement: When listing available watchdogs, print identity and driver of each watchdog. Reason: Previously, only watchdog path was printed, which was not enough for the users to figure out the right watchdog in case tehre were more than one. Result: Watchdog listing now includes watchdog path, identity and driver, so that it is possible to distinguish the watchdogs.
    • Proposed
    • None

      Description of problem

      The current output of `pcs stonith sbd watchdog list` provides only the /dev/watchdog* names of the devices. This is not very useful without taking the additional step of running `wdctl /dev/watchdog<num>` to check the identity of the device (especially if a machine has multiple watchdog devices available).

       

      [root@rhel-8-0-3 sosreport-rhel-8-0-3-00000000-2019-02-05-mpoisxd]# pcs stonith sbd watchdog list
Available watchdog(s):
  /dev/watchdog
  /dev/watchdog0
[root@rhel-8-0-3 sosreport-rhel-8-0-3-00000000-2019-02-05-mpoisxd]# wdctl /dev/watchdog0
Device:        /dev/watchdog0
Identity:      i6300ESB timer [version 0]
Timeout:       30 seconds
Pre-timeout:    0 seconds
FLAG           DESCRIPTION               STATUS BOOT-STATUS
KEEPALIVEPING  Keep alive ping reply          1           0
MAGICCLOSE     Supports magic close char      1           0
SETTIMEOUT     Set timeout (in seconds)       0           0

       

      The `sbd query-watchdog` command, in contrast, prints the identity of the watchdog device.

      [root@rhel-8-0-3 sosreport-rhel-8-0-3-00000000-2019-02-05-mpoisxd]# sbd query-watchdog
Discovered 2 watchdog devices:
[1] /dev/watchdog
Identity: i6300ESB timer
Driver: <unknown>
[2] /dev/watchdog0
Identity: i6300ESB timer
Driver: <unknown>

      It would be nice for the `pcs` subcommand to include the identity of the device(s).

      Version-Release number of selected component (if applicable)

      pcs-0.10.0.alpha.6-2.el8.x86_64

      How reproducible

      Always

      Steps to Reproduce

      Run `pcs stonith sbd watchdog list` on a machine where sbd is installed.

      Actual results

      Only the /dev/watchdog* names of the devices print.

      Expected results

      The /dev/watchdog* names and the identities of the devices print.

      Additional information

      We could consider a similar addition to the `pcs stonith sbd config` output. (Node rhel-8-0-4 is offline below.)

      [root@rhel-8-0-3 sosreport-rhel-8-0-3-00000000-2019-02-05-mpoisxd]# pcs stonith sbd config
Warning: Unable to connect to rhel-8-0-4 (Failed to connect to rhel-8-0-4 port 2224: No route to host)
Warning: Unable to get SBD configuration from node 'rhel-8-0-4'
SBD_STARTMODE=always
SBD_DELAY_START=no
SBD_WATCHDOG_TIMEOUT=5
Watchdogs:
  rhel-8-0-3: /dev/watchdog
  rhel-8-0-4: <unknown>

       

            [RHEL-76176] [RFE] Include device identity in `pcs stonith sbd watchdog list` output [rhel-10]

            Tomas Jelinek added a comment -

            Upstream patch: https://github.com/ClusterLabs/pcs/commit/83d9ba4b6a3f8ecfdc4594995669d95de5d8fd2d

             

            [root@rh100-node1:~]# pcs stonith sbd watchdog list
Available watchdog(s):
  /dev/watchdog
    Identity: i6300ESB timer
    Driver: <unknown>
  /dev/watchdog0
    Identity: i6300ESB timer
    Driver: <unknown>
  /dev/watchdog1
    Identity: iTCO_wdt
    Driver: iTCO_wdt

            Determining identity of a watchdog may cause the watchdog to reboot the machine. Because of that, the identity is only printed in 'pcs stonith sbd watchdog list' and not in other commands like 'pcs stonith sbd config'.

             

            Tomas Jelinek added a comment - Upstream patch: https://github.com/ClusterLabs/pcs/commit/83d9ba4b6a3f8ecfdc4594995669d95de5d8fd2d   [root@rh100-node1:~]# pcs stonith sbd watchdog list Available watchdog(s):   /dev/watchdog     Identity: i6300ESB timer     Driver: <unknown>   /dev/watchdog0     Identity: i6300ESB timer     Driver: <unknown>   /dev/watchdog1     Identity: iTCO_wdt     Driver: iTCO_wdt Determining identity of a watchdog may cause the watchdog to reboot the machine. Because of that, the identity is only printed in 'pcs stonith sbd watchdog list' and not in other commands like 'pcs stonith sbd config'.  

              mpospisi@redhat.com Michal Pospisil
              tojeline@redhat.com Tomas Jelinek
              Tomas Jelinek Tomas Jelinek
              Cluster QE Cluster QE
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated: